fix: foundry submodule issue, add no profit aave test

Author: glitch003

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "packages/libs/contracts-sdk/lib/forge-std"]
+	path = packages/libs/contracts-sdk/lib/forge-std
+	url = https://github.com/foundry-rs/forge-std

packages/libs/contracts-sdk/lib/forge-std

@@ -162,4 +162,63 @@ contract FeeForkTest is Test {
         tokensWithCollectedFees = feeAdminFacet.tokensWithCollectedFees();
         assertEq(tokensWithCollectedFees.length, 0);
     }
+
+    function testSingleDepositAndWithdrawFromAaveWithNoProfit() public {
+        uint256 depositAmount = 50 * 10 ** erc20Decimals;
+
+        // mint the USDC to the user
+        vm.startPrank(USDC_MINTER);
+        underlyingERC20.mint(APP_USER_ALICE, depositAmount);
+        vm.stopPrank();
+        console.log("minted USDC to user");
+
+        vm.startPrank(APP_USER_ALICE);
+        underlyingERC20.approve(address(aavePerfFeeFacet), depositAmount);
+        console.log("approved USDC to aave");
+        aavePerfFeeFacet.depositToAave(REAL_USDC, depositAmount);
+        vm.stopPrank();
+        console.log("deposited to aave");
+
+        LibFeeStorage.Deposit memory d = feeViewsFacet.deposits(APP_USER_ALICE, REAL_USDC);
+
+        assertEq(d.assetAmount, depositAmount);
+        console.log("d.vaultShares", d.vaultShares);
+        console.log("d.vaultProvider", d.vaultProvider);
+
+        // confirm that the fee contract has the aTokens
+        ERC20 aToken = ERC20(aavePool.getReserveAToken(REAL_USDC));
+        uint256 feeContractAaveTokens = aToken.balanceOf(address(aavePerfFeeFacet));
+        console.log("feeContractAaveTokens", feeContractAaveTokens);
+        // due to aave fees / rounding math, we get back 1 less aToken than we deposited
+        assertEq(feeContractAaveTokens / 10 ** aToken.decimals(), (depositAmount / 10 ** erc20Decimals) - 1);
+
+        // now, do the withdrawal
+        vm.startPrank(APP_USER_ALICE);
+        aavePerfFeeFacet.withdrawFromAave(REAL_USDC);
+        vm.stopPrank();
+
+        // confirm the deposit is zeroed out
+        d = feeViewsFacet.deposits(APP_USER_ALICE, REAL_USDC);
+
+        assertEq(d.assetAmount, 0);
+        assertEq(d.vaultShares, 0);
+        assertEq(d.vaultProvider, 0);
+
+        // confirm the profit went to the fee contract, and some went to the user
+        uint256 userBalance = underlyingERC20.balanceOf(APP_USER_ALICE);
+        uint256 feeContractBalance = underlyingERC20.balanceOf(address(aavePerfFeeFacet));
+
+        console.log("depositAmount", depositAmount);
+        console.log("userBalance", userBalance);
+
+        // The user's balance is exactly depositAmount - 1 due to aave aToken math and fee rounding:
+        // When withdrawing, aave converts the aTokens back to assets, and due to integer division/rounding,
+        // the user receives one less unit than deposited. This is expected for this test scenario.
+        assertEq(userBalance, depositAmount - 1);
+        assertEq(feeContractBalance, 0);
+
+        // test that the MockERC20 is not in the set of tokens that have collected fees
+        address[] memory tokensWithCollectedFees = feeAdminFacet.tokensWithCollectedFees();
+        assertEq(tokensWithCollectedFees.length, 0);
+    }
 }