chore(dashboard): resolve PR comments

Author: awisniew207

packages/apps/app-dashboard/src/components/explorer/ui/FeaturedApps.tsx

@@ -96,13 +96,13 @@ export function FeaturedApps({ apps, onNavigate }: FeaturedAppsProps) {
   );
 
   const featuredAppIds = VITE_FEATURED_APP_IDS
-    ? VITE_FEATURED_APP_IDS.split(',').map((id: string) => id.trim())
+    ? VITE_FEATURED_APP_IDS.split(',').map((id: string) => Number(id.trim()))
     : [];
 
   // Filter apps to only include featured ones, in the order specified
   const featuredApps = featuredAppIds
-    .map((appId: string) => {
-      const found = apps.find((app: App) => String(app.appId) === String(appId));
+    .map((appId: number) => {
+      const found = apps.find((app: App) => app.appId === appId);
       return found;
     })
     .filter((app: App | undefined): app is App => app !== undefined);

packages/apps/app-dashboard/src/components/user-dashboard/connect/DeletedAppConnect.tsx

@@ -91,7 +91,7 @@ export function DeletedAppConnect({
     } finally {
       setIsUnpermitting(false);
     }
-  }, [agentPKP, authInfo, sessionSigs, appData.appId, permittedVersion, navigate]);
+  }, [agentPKP, authInfo, sessionSigs, appData.appId, permittedVersion]);
 
   return (
     <div

packages/apps/app-dashboard/src/components/user-dashboard/connect/DeletedAppErrorScreen.tsx

@@ -87,7 +87,7 @@ export function DeletedAppErrorScreen({
     } finally {
       setIsUnpermitting(false);
     }
-  }, [agentPKP, authInfo, sessionSigs, appData.appId, permittedVersion, navigate]);
+  }, [agentPKP, authInfo, sessionSigs, appData.appId, permittedVersion]);
 
   return (
     <div className="w-full max-w-4xl mx-auto relative z-10 space-y-3 sm:space-y-4 lg:space-y-6">

packages/apps/app-dashboard/src/components/user-dashboard/dashboard/PermittedAppsWrapper.tsx

@@ -44,18 +44,41 @@ export function PermittedAppsWrapper() {
   const { permittedApps, unpermittedApps, deletedApps } = useMemo(() => {
     if (!allApps) return { permittedApps: [], unpermittedApps: [], deletedApps: [] };
 
-    const permittedAppIds = new Set(permittedPkps.filter((p) => !p.isDeleted).map((p) => p.appId));
-    const unpermittedAppIds = new Set(
-      unpermittedPkps.filter((p) => !p.isDeleted).map((p) => p.appId),
-    );
-    const deletedAppIds = new Set([
-      ...permittedPkps.filter((p) => p.isDeleted).map((p) => p.appId),
-      ...unpermittedPkps.filter((p) => p.isDeleted).map((p) => p.appId),
-    ]);
-
-    const permitted = allApps.filter((app) => permittedAppIds.has(app.appId));
-    const unpermitted = allApps.filter((app) => unpermittedAppIds.has(app.appId));
-    const deleted = allApps.filter((app) => deletedAppIds.has(app.appId));
+    // Build sets of appIds for each category in a single pass
+    const permittedAppIds = new Set<number>();
+    const unpermittedAppIds = new Set<number>();
+    const deletedAppIds = new Set<number>();
+
+    permittedPkps.forEach((p) => {
+      if (p.isDeleted) {
+        deletedAppIds.add(p.appId);
+      } else {
+        permittedAppIds.add(p.appId);
+      }
+    });
+
+    unpermittedPkps.forEach((p) => {
+      if (p.isDeleted) {
+        deletedAppIds.add(p.appId);
+      } else {
+        unpermittedAppIds.add(p.appId);
+      }
+    });
+
+    // Categorize apps in a single pass
+    const permitted: typeof allApps = [];
+    const unpermitted: typeof allApps = [];
+    const deleted: typeof allApps = [];
+
+    allApps.forEach((app) => {
+      if (deletedAppIds.has(app.appId)) {
+        deleted.push(app);
+      } else if (permittedAppIds.has(app.appId)) {
+        permitted.push(app);
+      } else if (unpermittedAppIds.has(app.appId)) {
+        unpermitted.push(app);
+      }
+    });
 
     return { permittedApps: permitted, unpermittedApps: unpermitted, deletedApps: deleted };
   }, [allApps, permittedPkps, unpermittedPkps]);

packages/apps/app-dashboard/src/components/user-dashboard/wallet/WalletModal.tsx

@@ -1,4 +1,5 @@
 import React, { useState } from 'react';
+import { createPortal } from 'react-dom';
 import { motion, AnimatePresence } from 'framer-motion';
 import { Button } from '@/components/shared/ui/button';
 import { theme, fonts } from '@/components/user-dashboard/connect/ui/theme';
@@ -604,7 +605,7 @@ export const WalletModal: React.FC<WalletModalProps> = ({ isOpen, onClose }) =>
     }
   };
 
-  return (
+  return createPortal(
     <>
       <AnimatePresence>
         {isOpen && (
@@ -615,7 +616,7 @@ export const WalletModal: React.FC<WalletModalProps> = ({ isOpen, onClose }) =>
               animate={{ opacity: 1 }}
               exit={{ opacity: 0 }}
               transition={{ duration: 0.2 }}
-              className="fixed inset-0 bg-black/50 z-50"
+              className="fixed inset-0 bg-black/50 z-[100]"
               onClick={onClose}
             />
 
@@ -629,7 +630,7 @@ export const WalletModal: React.FC<WalletModalProps> = ({ isOpen, onClose }) =>
                 stiffness: 300,
                 damping: 30,
               }}
-              className="fixed inset-0 flex items-start justify-center pt-16 sm:pt-20 md:pt-24 p-4 z-50 pointer-events-none md:pl-64"
+              className="fixed inset-0 flex items-center justify-center p-4 z-[100] pointer-events-none md:pl-64"
             >
               <div
                 className={`w-full max-w-md mx-auto ${theme.mainCard} border ${theme.mainCardBorder} rounded-2xl shadow-2xl overflow-hidden pointer-events-auto`}
@@ -671,6 +672,7 @@ export const WalletModal: React.FC<WalletModalProps> = ({ isOpen, onClose }) =>
           </motion.div>
         )}
       </AnimatePresence>
-    </>
+    </>,
+    document.body,
   );
 };

packages/apps/app-dashboard/src/hooks/developer-dashboard/useVincentApiWithJWT.ts

@@ -16,7 +16,7 @@ type StoredJWT = {
 const JWT_STORAGE_KEY = 'platformUserJWT';
 const EXPECTED_AUDIENCE =
   VITE_ENV === 'development'
-    ? 'http://localhost:5173'
+    ? 'http://localhost:3000'
     : VITE_ENV === 'staging'
       ? 'staging.registry.heyvincent.ai'
       : 'registry.heyvincent.ai';