chore: addressing pr feedback

Author: spacesailor24

packages/apps/ability-hyperliquid/src/generated/lit-action.js

@@ -1,3 +1,3 @@
 {
-  "ipfsCid": "QmQtGCkrvTJsLvvLvZWFhtrschv7N3SDC3nMzFQY95pkt1"
+  "ipfsCid": "QmaGop5dGvYeGpLd19FPH2i8fDqnHAHSgzyuhmetUqmU3C"
 }

packages/apps/ability-hyperliquid/src/generated/vincent-ability-metadata.json

@@ -0,0 +1,10 @@
+export const getHyperliquidChainId = (useTestnet: boolean): string => {
+  // Select chain ID and network based on testnet flag
+  return useTestnet
+    ? '0x66eee' // Arbitrum Sepolia testnet chain ID: 421614
+    : '0xa4b1'; // Arbitrum mainnet chain ID: 42161
+};
+
+export const getHyperliquidChainName = (useTestnet: boolean): string => {
+  return useTestnet ? 'Testnet' : 'Mainnet';
+};

packages/apps/ability-hyperliquid/src/lib/ability-helpers/get-hyperliquid-chain-id.ts

@@ -11,6 +11,7 @@ import { bigIntReplacer } from '@lit-protocol/vincent-ability-sdk';
 
 import { LitActionPkpEthersWallet } from './lit-action-pkp-ethers-wallet';
 import { getHyperliquidNonce } from './get-hyperliquid-nonce';
+import { getHyperliquidChainId, getHyperliquidChainName } from './get-hyperliquid-chain-id';
 
 export type SendPerpUsdcResult = {
   sendResult: SuccessResponse;
@@ -35,18 +36,12 @@ export async function sendPerpUsdc({
   const pkpWallet = new LitActionPkpEthersWallet(pkpPublicKey);
   const nonce = await getHyperliquidNonce();
 
-  // Select chain ID and network based on testnet flag
-  const signatureChainId = useTestnet
-    ? '0x66eee' // Arbitrum Sepolia testnet chain ID: 421614
-    : '0xa4b1'; // Arbitrum mainnet chain ID: 42161
-  const hyperliquidChain = useTestnet ? 'Testnet' : 'Mainnet';
-
   // Construct send action
   // UsdSend uses standard 6 decimals for USDC (not Hyperliquid's 8 decimal precision)
   const sendAction = parser(UsdSendRequest.entries.action)({
     type: 'usdSend',
-    signatureChainId,
-    hyperliquidChain,
+    signatureChainId: getHyperliquidChainId(useTestnet),
+    hyperliquidChain: getHyperliquidChainName(useTestnet),
     destination,
     // Convert amount from micro-units (6 decimals) to human-readable format
     // e.g., "1000000" -> "1.0"

packages/apps/ability-hyperliquid/src/lib/ability-helpers/send-perp-usdc.ts

@@ -11,6 +11,7 @@ import { bigIntReplacer } from '@lit-protocol/vincent-ability-sdk';
 
 import { LitActionPkpEthersWallet } from './lit-action-pkp-ethers-wallet';
 import { getHyperliquidNonce } from './get-hyperliquid-nonce';
+import { getHyperliquidChainId, getHyperliquidChainName } from './get-hyperliquid-chain-id';
 
 export type SendSpotAssetResult = {
   sendResult: SuccessResponse;
@@ -48,17 +49,11 @@ export async function sendSpotAsset({
   }
   console.log('[sendAsset] Token info:', tokenInfo);
 
-  // Select chain ID and network based on testnet flag
-  const signatureChainId = useTestnet
-    ? '0x66eee' // Arbitrum Sepolia testnet chain ID: 421614
-    : '0xa4b1'; // Arbitrum mainnet chain ID: 42161
-  const hyperliquidChain = useTestnet ? 'Testnet' : 'Mainnet';
-
   // Construct send action
   const sendAction = parser(SpotSendRequest.entries.action)({
     type: 'spotSend',
-    signatureChainId,
-    hyperliquidChain,
+    signatureChainId: getHyperliquidChainId(useTestnet),
+    hyperliquidChain: getHyperliquidChainName(useTestnet),
     destination,
     // Construct token identifier in the format expected by SpotSend: "name:0xaddress"
     token: `${tokenInfo.name}:${tokenInfo.tokenId}`,

packages/apps/ability-hyperliquid/src/lib/ability-helpers/send-spot-asset.ts

@@ -11,6 +11,7 @@ import { bigIntReplacer } from '@lit-protocol/vincent-ability-sdk';
 
 import { LitActionPkpEthersWallet } from './lit-action-pkp-ethers-wallet';
 import { getHyperliquidNonce } from './get-hyperliquid-nonce';
+import { getHyperliquidChainId, getHyperliquidChainName } from './get-hyperliquid-chain-id';
 
 export type TransferUsdcResult = {
   transferResult: SuccessResponse;
@@ -40,19 +41,13 @@ export async function transferUsdcTo({
 
   const nonce = await getHyperliquidNonce();
 
-  // Select chain ID and network based on testnet flag
-  const signatureChainId = useTestnet
-    ? '0x66eee' // Arbitrum Sepolia testnet chain ID: 421614
-    : '0xa4b1'; // Arbitrum mainnet chain ID: 42161
-  const hyperliquidChain = useTestnet ? 'Testnet' : 'Mainnet';
-
   const transferAction = parser(UsdClassTransferRequest.entries.action)({
     type: 'usdClassTransfer',
     // Convert amount from raw units (e.g., "1000000" for 1.0 USDC) to formatted string (e.g., "1.0")
     // Hyperliquid expects the amount as a string in human-readable format
     amount: ethers.utils.formatUnits(amount, 6),
-    signatureChainId,
-    hyperliquidChain,
+    signatureChainId: getHyperliquidChainId(useTestnet),
+    hyperliquidChain: getHyperliquidChainName(useTestnet),
     toPerp: to === 'perp',
     nonce,
   });

packages/apps/ability-hyperliquid/src/lib/ability-helpers/transfer-usdc-to.ts

@@ -11,6 +11,7 @@ import { bigIntReplacer } from '@lit-protocol/vincent-ability-sdk';
 
 import { LitActionPkpEthersWallet } from './lit-action-pkp-ethers-wallet';
 import { getHyperliquidNonce } from './get-hyperliquid-nonce';
+import { getHyperliquidChainId, getHyperliquidChainName } from './get-hyperliquid-chain-id';
 
 export type WithdrawUsdcResult = {
   withdrawResult: SuccessResponse;
@@ -36,17 +37,11 @@ export async function withdrawUsdc({
   const pkpWallet = new LitActionPkpEthersWallet(pkpPublicKey);
   const nonce = await getHyperliquidNonce();
 
-  // Select chain ID and network based on testnet flag
-  const signatureChainId = useTestnet
-    ? '0x66eee' // Arbitrum Sepolia testnet chain ID: 421614
-    : '0xa4b1'; // Arbitrum mainnet chain ID: 42161
-  const hyperliquidChain = useTestnet ? 'Testnet' : 'Mainnet';
-
   // Construct withdraw action
   const withdrawAction = parser(Withdraw3Request.entries.action)({
     type: 'withdraw3',
-    signatureChainId,
-    hyperliquidChain,
+    signatureChainId: getHyperliquidChainId(useTestnet),
+    hyperliquidChain: getHyperliquidChainName(useTestnet),
     destination,
     // Convert amount from raw units (e.g., "1000000" for 1.0 USDC) to formatted string (e.g., "1.0")
     // Hyperliquid expects the amount as a string in human-readable format