Merge pull request #69 from LIT-Protocol/wyatt/wrapped-keys-eip-712

Add test for EIP-191 signing

Author: spacesailor24

wrapped-keys/eip-712/nodejs/src/index.ts

@@ -26,7 +26,10 @@ const CAPACITY_CREDIT_TOKEN_ID =
 const LIT_NETWORK =
   (process.env.LIT_NETWORK as LitNetwork) || LitNetwork.DatilTest;
 
-export const runExample = async (serializedEip712Message: string) => {
+export const runExample = async (
+  messageToSign: string,
+  useEip712Signing: boolean
+) => {
   let litNodeClient: LitNodeClient;
 
   try {
@@ -102,8 +105,8 @@ export const runExample = async (serializedEip712Message: string) => {
         ],
         ciphertext: wrappedKeyMetadata.ciphertext,
         dataToEncryptHash: wrappedKeyMetadata.dataToEncryptHash,
-        messageToSign: serializedEip712Message,
-        useEip712Signing: true,
+        messageToSign,
+        useEip712Signing,
       },
     });
     console.log("✅ Signed EIP-712 message");

wrapped-keys/eip-712/nodejs/src/wrappedKeyLitAction.ts

@@ -46,7 +46,7 @@ async function signMessageEthereumKey({ privateKey, messageToSign }) {
   const wallet = new ethers.Wallet(privateKey);
 
   let signature;
-  if (useEip712Signing ?? false) {
+  if (useEip712Signing) {
     const { domain, types, message } = JSON.parse(messageToSign);
 
     signature = await wallet._signTypedData(domain, types, message);

wrapped-keys/eip-712/nodejs/test/index.spec.ts

@@ -49,11 +49,13 @@ describe("Signing an EIP-712 message using a Wrapped Key", () => {
     );
 
     const { signedMessage, wrappedKeyEthAddress } = (await runExample(
-      serializedEip712Message
+      serializedEip712Message,
+      true
     )) ?? { signedMessage: "", wrappedKeyEthAddress: "" };
     expect(signedMessage).to.not.equal("");
     expect(wrappedKeyEthAddress).to.not.equal("");
 
+    // Verify the signature using EIP-712
     const recoveredAddress = ethers.utils.verifyTypedData(
       domain,
       types,
@@ -63,3 +65,20 @@ describe("Signing an EIP-712 message using a Wrapped Key", () => {
     expect(recoveredAddress).to.equal(wrappedKeyEthAddress);
   }).timeout(120_000);
 });
+
+describe("Signing a EIP-191 message using a Wrapped Key", () => {
+  it("should return signed EIP-191 message", async () => {
+    const message = "Hello, World!";
+
+    const { signedMessage, wrappedKeyEthAddress } = (await runExample(
+      message,
+      false
+    )) ?? { signedMessage: "", wrappedKeyEthAddress: "" };
+    expect(signedMessage).to.not.equal("");
+    expect(wrappedKeyEthAddress).to.not.equal("");
+
+    // Verify the signature using EIP-191
+    const recoveredAddress = ethers.utils.verifyMessage(message, signedMessage);
+    expect(recoveredAddress).to.equal(wrappedKeyEthAddress);
+  }).timeout(120_000);
+});