Merge pull request #663 from LIT-Protocol/feature/lit-3918-no-globalthis-variables-anymore

Feature/lit 3918 no globalthis variables anymore

Author: FedericoAmura

packages/access-control-conditions/README.md

@@ -7,12 +7,3 @@ This submodule provides functionalities for formatting and canonicalizing data,
 ```
 yarn add @lit-protocol/access-control-conditions
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/access-control-conditions-vanilla/access-control-conditions.js"></script>
-<script>
-  console.log(LitJsSdk_accessControlConditions);
-</script>
-```

packages/auth-browser/README.md

@@ -8,15 +8,6 @@ This submodule provides functionalities from various modules within the Lit SDK,
 yarn add @lit-protocol/auth-browser
 ```
 
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/auth-browser-vanilla/auth-browser.js"></script>
-<script>
-  console.log(LitJsSdk_authBrowser);
-</script>
-```
-
 ## Generate an authSig with long expiration
 
 ```

packages/auth-browser/src/lib/chains/eth.ts

@@ -7,7 +7,10 @@ import { toUtf8Bytes } from '@ethersproject/strings';
 
 // import WalletConnectProvider from '@walletconnect/ethereum-provider';
 import { verifyMessage } from '@ethersproject/wallet';
-import { EthereumProvider } from '@walletconnect/ethereum-provider';
+import {
+  EthereumProvider,
+  default as WalletConnectProvider,
+} from '@walletconnect/ethereum-provider';
 import { ethers } from 'ethers';
 import { getAddress } from 'ethers/lib/utils';
 import { SiweMessage } from 'siwe';
@@ -128,6 +131,8 @@ export type WALLET_ERROR_VALUES =
 
 /** ---------- Local Helpers ---------- */
 
+let litWCProvider: WalletConnectProvider | undefined;
+
 /**
  *
  * Convert chain hex id to chain name
@@ -386,8 +391,7 @@ export const connectWeb3 = async ({
     };
 
     if (isBrowser()) {
-      // @ts-ignore
-      globalThis.litWCProvider = wcProvider;
+      litWCProvider = wcProvider;
     }
   }
 
@@ -440,10 +444,9 @@ export const disconnectWeb3 = (): void => {
   }
 
   // @ts-ignore
-  if (isBrowser() && globalThis.litWCProvider) {
+  if (isBrowser() && litWCProvider) {
     try {
-      // @ts-ignore
-      globalThis.litWCProvider.disconnect();
+      litWCProvider.disconnect();
     } catch (err) {
       log(
         'Attempted to disconnect global WalletConnectProvider for lit-connect-modal',

packages/auth-helpers/README.md

@@ -7,12 +7,3 @@ This submodule manages permissions and capabilities related to accessing specifi
 ```
 yarn add @lit-protocol/auth-helpers
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/auth-helpers-vanilla/auth-helpers.js"></script>
-<script>
-  console.log(LitJsSdk_authHelpers);
-</script>
-```

packages/constants/README.md

@@ -7,12 +7,3 @@ This submodule exports various modules, constants, interfaces, errors, utilities
 ```
 yarn add @lit-protocol/constants
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/constants-vanilla/constants.js"></script>
-<script>
-  console.log(LitJsSdk_constants);
-</script>
-```

packages/contracts-sdk/README.md

@@ -6,22 +6,8 @@ Demo: https://demo-contracts-sdk-react.vercel.app/
 
 # Installation
 
-```js
-yarn add @lit-protocol/contracts-sdk
 ```
-
-# Vanilla JS (UMD)
-
-```html
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/contracts-sdk-vanilla/contracts-sdk.js"></script>
-<script>
-  (async () => {
-    const { LitContracts } = LitJsSdk_contractsSdk;
-
-    const litContracts = new LitContracts();
-    await litContracts.connect();
-  })();
-</script>
+yarn add @lit-protocol/contracts-sdk
 ```
 
 # Quick Start

packages/core/src/lib/lit-core.ts

@@ -51,6 +51,7 @@ import {
   logWithRequestId,
   mostCommonString,
   sendRequest,
+  setMiscLitConfig,
 } from '@lit-protocol/misc';
 import {
   AuthSig,
@@ -200,7 +201,7 @@ export class LitCore {
     this.setCustomBootstrapUrls();
 
     // -- set global variables
-    globalThis.litConfig = this.config;
+    setMiscLitConfig(this.config);
     bootstrapLogManager(
       'core',
       this.config.debug ? LogLevel.DEBUG : LogLevel.OFF
@@ -392,7 +393,7 @@ export class LitCore {
 
     this._stopListeningForNewEpoch();
     // this._stopNetworkPolling();
-    if (globalThis.litConfig) delete globalThis.litConfig;
+    setMiscLitConfig(undefined);
   }
 
   // _stopNetworkPolling() {
@@ -537,9 +538,6 @@ export class LitCore {
     // this._scheduleNetworkSync();
     this._listenForNewEpoch();
 
-    // FIXME: don't create global singleton; multiple instances of `core` should not all write to global
-    // @ts-expect-error typeof globalThis is not defined. We're going to get rid of the global soon.
-    globalThis.litNodeClient = this;
     this.ready = true;
 
     log(`🔥 lit is ready. "litNodeClient" variable is ready to use globally.`);

packages/crypto/README.md

@@ -7,12 +7,3 @@ The crypto.ts file in the Lit SDK handles cryptographic operations, including th
 ```
 yarn add @lit-protocol/crypto
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/crypto-vanilla/crypto.js"></script>
-<script>
-  console.log(LitJsSdk_crypto);
-</script>
-```

packages/encryption/README.md

@@ -7,12 +7,3 @@ This submodule provides encryption and decryption of contents (string, file, etc
 ```
 yarn add @lit-protocol/encryption
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/encryption-vanilla/encryption.js"></script>
-<script>
-  console.log(LitJsSdk_encryption);
-</script>
-```

packages/lit-node-client-nodejs/src/index.ts

@@ -1,19 +1,5 @@
 import 'cross-fetch/dist/node-polyfill.js';
 
-import * as _LitNodeClientNodeJs from './lib/lit-node-client-nodejs';
-// ==================== Environment ====================
-
-declare global {
-  // This `declare global` hackery _must_ use var to work.
-  // eslint-disable-next-line no-var, @typescript-eslint/no-explicit-any
-  var LitNodeClientNodeJs: any;
-}
-
-const LitNodeClientNodeJs = _LitNodeClientNodeJs.LitNodeClientNodeJs;
-if (!globalThis.LitNodeClientNodeJs) {
-  globalThis.LitNodeClientNodeJs = LitNodeClientNodeJs;
-}
-
 // ==================== Exports ====================
 export * from './lib/lit-node-client-nodejs';