feat(e2e): payment delegation flow

Author: Ansonhkg

packages/e2e/src/helper/createEnvVars.ts

@@ -19,7 +19,7 @@ const testEnv: Record<
 
 export function createEnvVars(): EnvVars {
   // 1. Get network string
-  const network = process.env['NETWORK']!!;
+  const network = process.env['NETWORK']!!; 
 
   if (!network || !supportedNetworks.includes(network as any)) {
     throw new Error(

packages/e2e/src/helper/createTestAccount.ts

@@ -16,7 +16,7 @@ type CreateTestAccountOpts = {
   fundPKPLedger: boolean;
   sponsor?: {
     restrictions: {
-      totalMaxPriceInEth: string;
+      totalMaxPriceInWei: string;
       requestsPerPeriod: string;
       periodSeconds: string;
     };
@@ -153,17 +153,18 @@ export async function createTestAccount(
     // 2. Set Restrictions
 
     // Convert to Wei using Viem
-    const wei = parseEther(opts.sponsor.restrictions.totalMaxPriceInEth);
-
-    console.log(`- Setting sponsorship restrictions:`, {
-      totalMaxPriceInEth: opts.sponsor.restrictions.totalMaxPriceInEth,
-      totalMaxPriceInWei: wei.toString(),
-      requestsPerPeriod: opts.sponsor.restrictions.requestsPerPeriod,
-      periodSeconds: opts.sponsor.restrictions.periodSeconds,
-    });
+    // const wei = parseEther(opts.sponsor.restrictions.totalMaxPriceInEth);
+
+    // console.log(`- Setting sponsorship restrictions:`, {
+    //   totalMaxPriceInEth: opts.sponsor.restrictions.totalMaxPriceInEth,
+    //   totalMaxPriceInWei: wei.toString(),
+    //   requestsPerPeriod: opts.sponsor.restrictions.requestsPerPeriod,
+    //   periodSeconds: opts.sponsor.restrictions.periodSeconds,
+    // });
     try {
       const tx = await personPaymentManager.setRestriction({
-        totalMaxPrice: wei.toString(),
+        // totalMaxPrice: wei.toString(),
+        totalMaxPrice: opts.sponsor.restrictions.totalMaxPriceInWei,
         requestsPerPeriod: opts.sponsor.restrictions.requestsPerPeriod,
         periodSeconds: opts.sponsor.restrictions.periodSeconds,
       });

packages/e2e/src/tickets/delegation.spec.ts

@@ -21,12 +21,16 @@ describe('payment delegation test', () => {
     bobAccount = await createTestAccount(testEnv, {
       label: 'Bob',
       fundAccount: true,
-      fundLedger: true,
+      hasEoaAuthContext: true,
+      fundLedger: false,
       hasPKP: true,
-      fundPKP: true,
-      fundPKPLedger: true,
+      fundPKP: false,
+      hasPKPAuthContext: false,
+      fundPKPLedger: false,
     });
 
+    console.log('bobAccount:', bobAccount);
+
     if (!bobAccount.pkp?.ethAddress) {
       throw new Error("Bob's PKP does not have an ethAddress");
     }
@@ -35,27 +39,74 @@ describe('payment delegation test', () => {
     alice = await createTestAccount(testEnv, {
       label: 'Alice',
       fundAccount: true,
-      fundLedger: false,
+      fundLedger: true,
       hasPKP: true,
       fundPKP: true,
       fundPKPLedger: true,
       sponsor: {
         restrictions: {
-          totalMaxPriceInEth: '0.05',
+          totalMaxPriceInWei: '1000000000000000000',
           requestsPerPeriod: '100',
           periodSeconds: '5',
         },
-        userAddresses: [bobAccount.pkp.ethAddress],
+        userAddresses: [bobAccount.account.address],
       },
     });
 
-    // 3. Now, Bob tries to execute JS using Alice's sponsorship
-    const res = await testEnv.litClient.chain.ethereum.pkpSign({
-      authContext: bobAccount.pkpAuthContext!,
+    // 3. Take a snapshot of Alice's Ledger balance before Bob's request
+    const aliceBeforeBalance = await testEnv.masterPaymentManager.getBalance({
+      userAddress: alice.account.address,
+    });
+
+    console.log(
+      "[BEFORE] Alice's Ledger balance before Bob's request:",
+      aliceBeforeBalance
+    );
+
+    // 3. Now, Bob tries to sign with his PKP using Alice's sponsorship
+    await testEnv.litClient.chain.ethereum.pkpSign({
+      authContext: bobAccount.eoaAuthContext!,
       pubKey: bobAccount.pkp?.pubkey!,
       toSign: 'Hello, world!',
+      userMaxPrice: 200000000000000000n, // 0.2 ETH in Wei
+    });
+
+    // 4. Finally, check that Alice's Ledger balance has decreased
+    const aliceBalanceAfter = await testEnv.masterPaymentManager.getBalance({
+      userAddress: alice.account.address,
     });
 
-    console.log('res:', res);
+    console.log(
+      "[AFTER] Alice's Ledger balance after Bob's request:",
+      aliceBalanceAfter
+    );
+
+    expect(BigInt(aliceBalanceAfter.raw.availableBalance)).toBeLessThan(
+      BigInt(aliceBeforeBalance.raw.availableBalance)
+    );
+
+    // 5. Now, Alice removes Bob from her sponsorship
+    await alice.paymentManager!.undelegatePaymentsBatch({
+      userAddresses: [bobAccount.account.address],
+    });
+
+    // 6. Bob should now fail to sign with his PKP due to lack of sponsorship
+    let didFail = false;
+    try {
+      await testEnv.litClient.chain.ethereum.pkpSign({
+        authContext: bobAccount.eoaAuthContext!,
+        pubKey: bobAccount.pkp?.pubkey!,
+        toSign: 'Hello again, world!',
+        userMaxPrice: 200000000000000000n, // 0.2 ETH in Wei
+      });
+    } catch (e) {
+      didFail = true;
+      console.log(
+        "As expected, Bob's PKP sign failed after Alice removed sponsorship:",
+        e
+      );
+    }
+
+    expect(didFail).toBe(true);
   });
 });

packages/networks/src/networks/vNaga/shared/managers/session-manager/issueSessionFromContext.ts

@@ -97,10 +97,19 @@ export const issueSessionFromContext = async (params: {
   // console.log('🔄 _userMaxPrices', _userMaxPrices);
 
   _userMaxPrices.forEach(({ url: nodeAddress, price }) => {
+    // ❗️❗️ TEMPORARY FIX: Convert to hex client-side so the node sees the
+    // intended wei cap until it supports decimal parsing.
+    // Reason: the node deserialises via `serde_json` into
+    // `ethers::types::U256`, which treats bare strings as hex. Sending our
+    // decimal bigint (e.g. "250000000000000000") therefore turns into the much
+    // larger 0x2500... amount.
+    const priceInWei = price;
+    const maxPriceHex = `0x${priceInWei.toString(16)}`;
+
     const toSign: SessionSigningTemplate = {
       ...sessionSigningTemplate,
       nodeAddress,
-      maxPrice: price.toString(),
+      maxPrice: maxPriceHex,
     };
 
     // console.log(`Setting maxprice for ${nodeAddress} to `, price.toString());