feat(lit-node-client): LIT-4207 - Remove node price tracking state from LitCore/LitNodeClient; use price-feed-info-manager instead

- Removed `nodePrices` array from `LitCore` config state; this would be redundant since we cache price feed info in the manager module now
- Update `getMaxPricesForNodeProduct()` on `LitNodeClient` to be an async method, since it will sometimes fetch new prices
- CHORE: Removed unused access control method imports from `lit-node-client-nodejs.ts`
- CHORE: Removed duplicate `export * from...` in constants/index.ts
- Added private `_getNodePrices()` method to LitNodeClient that calls the new `price-feed-info-manager` method w/ args from the current client config

Author: MaximusHaximus

packages/constants/src/index.ts

@@ -5,7 +5,6 @@ export * from './lib/version';
 export * from './lib/constants/constants';
 export * from './lib/constants/mappers';
 export * from './lib/constants/endpoints';
-export * from './lib/constants/mappers';
 export * from './lib/constants/curves';
 
 // ----------- Interfaces -----------

packages/core/src/lib/lit-core.ts

@@ -115,8 +115,6 @@ export type LitNodeClientConfigWithDefaults = Required<
     bootstrapUrls: string[];
   } & {
     nodeProtocol?: typeof HTTP | typeof HTTPS | null;
-  } & {
-    nodePrices: { url: string; prices: bigint[] }[]; // eg. <nodeAddress, price[]>
   };
 
 export class LitCore {
@@ -129,7 +127,6 @@ export class LitCore {
     minNodeCount: 2, // Default value, should be replaced
     bootstrapUrls: [], // Default value, should be replaced
     nodeProtocol: null,
-    nodePrices: [],
   };
   connectedNodes = new Set<string>();
   serverKeys: Record<string, JsonHandshakeResponse> = {};
@@ -504,7 +501,6 @@ export class LitCore {
     this._stakingContract = validatorData.stakingContract;
     this.config.minNodeCount = validatorData.minNodeCount;
     this.config.bootstrapUrls = validatorData.bootstrapUrls;
-    this.config.nodePrices = validatorData.nodePrices;
 
     this._epochState = await this._fetchCurrentEpochState(
       validatorData.epochInfo

packages/lit-node-client-nodejs/src/lib/lit-node-client-nodejs.ts

@@ -2,6 +2,11 @@ import { computeAddress } from '@ethersproject/transactions';
 import { ethers } from 'ethers';
 import { SiweMessage } from 'siwe';
 
+import {
+  getFormattedAccessControlConditions,
+  getHashedAccessControlConditions,
+  validateAccessControlConditions,
+} from '@lit-protocol/access-control-conditions';
 import {
   createSiweMessage,
   createSiweMessageWithCapacityDelegation,
@@ -34,6 +39,7 @@ import {
   UnsupportedMethodError,
   WalletSignatureNotFoundError,
 } from '@lit-protocol/constants';
+import { getNodePrices } from '@lit-protocol/contracts-sdk';
 import { composeLitUrl, LitCore } from '@lit-protocol/core';
 import {
   combineSignatureShares,
@@ -107,16 +113,17 @@ import {
   SigResponse,
   SuccessNodePromises,
 } from '@lit-protocol/types';
+import { AuthMethod } from '@lit-protocol/types';
 import {
   uint8arrayFromString,
   uint8arrayToString,
 } from '@lit-protocol/uint8arrays';
 
-import { AuthMethod } from '@lit-protocol/types';
 import { encodeCode } from './helpers/encode-code';
 import { getBlsSignatures } from './helpers/get-bls-signatures';
 import { getClaims } from './helpers/get-claims';
 import { getClaimsList } from './helpers/get-claims-list';
+import { getExpiration } from './helpers/get-expiration';
 import { getMaxPricesForNodeProduct } from './helpers/get-max-prices-for-node-product';
 import { getSignatures } from './helpers/get-signatures';
 import { normalizeArray } from './helpers/normalize-array';
@@ -126,12 +133,6 @@ import { parsePkpSignResponse } from './helpers/parse-pkp-sign-response';
 import { processLitActionResponseStrategy } from './helpers/process-lit-action-response-strategy';
 import { removeDoubleQuotes } from './helpers/remove-double-quotes';
 import { blsSessionSigVerify } from './helpers/validate-bls-session-sig';
-import {
-  getFormattedAccessControlConditions,
-  getHashedAccessControlConditions,
-  validateAccessControlConditions,
-} from '@lit-protocol/access-control-conditions';
-import { getExpiration } from './helpers/get-expiration';
 
 export class LitNodeClientNodeJs extends LitCore implements ILitNodeClient {
   /** Tracks the total max price a user is willing to pay for each supported product type
@@ -164,6 +165,15 @@ export class LitNodeClientNodeJs extends LitCore implements ILitNodeClient {
     this.defaultMaxPriceByProduct[product] = price;
   }
 
+  private _getNodePrices() {
+    return getNodePrices({
+      realmId: 1,
+      litNetwork: this.config.litNetwork,
+      networkContext: this.config.contractContext,
+      rpcUrl: this.config.rpcUrl,
+      nodeProtocol: this.config.nodeProtocol,
+    });
+  }
   // ========== Rate Limit NFT ==========
 
   // TODO: Add support for browser feature/lit-2321-js-sdk-add-browser-support-for-createCapacityDelegationAuthSig
@@ -673,7 +683,7 @@ export class LitNodeClientNodeJs extends LitCore implements ILitNodeClient {
 
     const requestId = this._getNewRequestId();
 
-    const userMaxPrices = this.getMaxPricesForNodeProduct({
+    const userMaxPrices = await this.getMaxPricesForNodeProduct({
       product: 'LIT_ACTION',
       userMaxPrice: params.userMaxPrice,
     });
@@ -866,7 +876,7 @@ export class LitNodeClientNodeJs extends LitCore implements ILitNodeClient {
 
     const requestId = this._getNewRequestId();
 
-    const targetNodePrices = this.getMaxPricesForNodeProduct({
+    const targetNodePrices = await this.getMaxPricesForNodeProduct({
       product: 'SIGN',
       userMaxPrice: params.userMaxPrice,
     });
@@ -1154,7 +1164,7 @@ export class LitNodeClientNodeJs extends LitCore implements ILitNodeClient {
     log('identityParam', identityParam);
 
     let sessionSigs: SessionSigsMap = {};
-    const userMaxPrices = this.getMaxPricesForNodeProduct({
+    const userMaxPrices = await this.getMaxPricesForNodeProduct({
       product: 'DECRYPTION',
       userMaxPrice: params.userMaxPrice,
     });
@@ -1343,7 +1353,7 @@ export class LitNodeClientNodeJs extends LitCore implements ILitNodeClient {
 
     // This may seem a bit weird because we usually only care about prices for sessionSigs...
     // But this also ensures we use the cheapest nodes and takes care of getting the minNodeCount of node URLs for the operation
-    const targetNodePrices = this.getMaxPricesForNodeProduct({
+    const targetNodePrices = await this.getMaxPricesForNodeProduct({
       product: 'LIT_ACTION',
     });
 
@@ -1536,7 +1546,7 @@ export class LitNodeClientNodeJs extends LitCore implements ILitNodeClient {
     });
   };
 
-  getMaxPricesForNodeProduct = ({
+  getMaxPricesForNodeProduct = async ({
     userMaxPrice,
     product,
   }: {
@@ -1564,7 +1574,7 @@ export class LitNodeClientNodeJs extends LitCore implements ILitNodeClient {
 
     console.log('getMaxPricesForNodeProduct():', {});
     return getMaxPricesForNodeProduct({
-      nodePrices: this.config.nodePrices,
+      nodePrices: await this._getNodePrices(),
       userMaxPrice: getUserMaxPrice(),
       productId: PRODUCT_IDS[product],
       numRequiredNodes: this._getThreshold(),
@@ -1914,7 +1924,7 @@ export class LitNodeClientNodeJs extends LitCore implements ILitNodeClient {
 
     // This may seem a bit weird because we usually only care about prices for sessionSigs...
     // But this also ensures we use the cheapest nodes and takes care of getting the minNodeCount of node URLs for the operation
-    const targetNodePrices = this.getMaxPricesForNodeProduct({
+    const targetNodePrices = await this.getMaxPricesForNodeProduct({
       product: 'LIT_ACTION',
     });
 

packages/types/src/lib/ILitNodeClient.ts

@@ -1,3 +1,5 @@
+import { PRODUCT_IDS } from '@lit-protocol/constants';
+
 import {
   AuthenticationContext,
   CapacityCreditsReq,
@@ -14,8 +16,6 @@ import {
   LitNodeClientConfig,
   SigResponse,
 } from './interfaces';
-
-import { PRODUCT_IDS } from '@lit-protocol/constants';
 import { ClaimProcessor, ClaimRequest } from './types';
 
 export interface ILitNodeClient {
@@ -58,7 +58,7 @@ export interface ILitNodeClient {
   getMaxPricesForNodeProduct(params: {
     userMaxPrice?: bigint;
     product: keyof typeof PRODUCT_IDS;
-  }): { url: string; price: bigint }[];
+  }): Promise<{ url: string; price: bigint }[]>;
 
   /**
    * Create capacity delegation authentication signature