chore(wrapped-keys-lit-actions): LIT-3920 - Update signTransactionWithEncryptedSolanaKey LA to validate unsigned tx before decrypting the private key

Author: MaximusHaximus

local-tests/test.ts

@@ -291,22 +291,22 @@ setLitActionsCodeToLocal();
     tests: {
       // testExample,
       // testBundleSpeed,
-      ...eoaSessionSigsTests,
-      ...pkpSessionSigsTests,
-      ...litActionSessionSigsTests,
-      ...litActionIpfsIdSessionSigsTests,
-      ...capacityDelegationTests,
-      ...bareAuthSigTests,
-
-      ...pkpEthersTest.eoaSessionSigs,
-      ...pkpEthersTest.pkpSessionSigs,
-      ...pkpEthersTest.litActionSessionSigs,
-
-      ...litActionCombiningTests.broadcastAndCombine,
-      ...litActionCombiningTests.decryptAndCombine,
-      ...litActionCombiningTests.ecdsaSignAndCombine,
-
-      ...relayerTests,
+      // ...eoaSessionSigsTests,
+      // ...pkpSessionSigsTests,
+      // ...litActionSessionSigsTests,
+      // ...litActionIpfsIdSessionSigsTests,
+      // ...capacityDelegationTests,
+      // ...bareAuthSigTests,
+      //
+      // ...pkpEthersTest.eoaSessionSigs,
+      // ...pkpEthersTest.pkpSessionSigs,
+      // ...pkpEthersTest.litActionSessionSigs,
+      //
+      // ...litActionCombiningTests.broadcastAndCombine,
+      // ...litActionCombiningTests.decryptAndCombine,
+      // ...litActionCombiningTests.ecdsaSignAndCombine,
+      //
+      // ...relayerTests,
       ...wrappedKeysTests,
     },
     devEnv,

packages/wrapped-keys-lit-actions/src/lib/solana/internal/signTransaction.js

@@ -7,7 +7,7 @@ const {
 
 /* global ethers */
 
-function validateUnsignedTransaction(unsignedTransaction) {
+export function validateUnsignedTransaction(unsignedTransaction) {
   const VALID_NETWORKS = ['devnet', 'testnet', 'mainnet-beta'];
 
   if (!VALID_NETWORKS.includes(unsignedTransaction.chain)) {
@@ -48,7 +48,7 @@ export async function signTransactionSolanaKey({
   privateKey,
   unsignedTransaction,
 }) {
-  validateUnsignedTransaction(unsignedTransaction);
+  // Be sure you call validateUnsignedTransaction(unsignedTransaction); before calling this method!
 
   const solanaKeyPair = Keypair.fromSecretKey(Buffer.from(privateKey, 'hex'));
 

packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithEncryptedSolanaKey.js

@@ -1,4 +1,7 @@
-const { signTransactionSolanaKey } = require('./internal/signTransaction');
+const {
+  signTransactionSolanaKey,
+  validateUnsignedTransaction,
+} = require('./internal/signTransaction');
 const {
   getDecryptedKeyToSingleNode,
 } = require('../common/internal/getDecryptedKeyToSingleNode');
@@ -22,6 +25,8 @@ const { removeSaltFromDecryptedKey } = require('../utils');
 
 (async () => {
   try {
+    validateUnsignedTransaction(unsignedTransaction);
+
     const decryptedPrivateKey = await getDecryptedKeyToSingleNode({
       accessControlConditions,
       ciphertext,