From ff273184cf41be694efe7c6d4619f5fc0f97f23e Mon Sep 17 00:00:00 2001 From: Anson Date: Wed, 25 Sep 2024 16:32:52 +0100 Subject: [PATCH 1/3] fix: wrong encoding - should be `base58` instead of `base64` --- .../src/lib/solana/signTransactionWithSolanaEncryptedKey.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js b/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js index 27926a6b01..b9c48ee572 100644 --- a/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js +++ b/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js @@ -6,6 +6,7 @@ const { } = require('@solana/web3.js'); const { removeSaltFromDecryptedKey } = require('../utils'); +const { bs58 } = require('bs58'); /** * @@ -80,7 +81,7 @@ const { removeSaltFromDecryptedKey } = require('../utils'); ); transaction.sign(solanaKeyPair); - const signature = transaction.signature.toString('base64'); + const signature = bs58.encode(transaction.signature); if (broadcast) { const solanaConnection = new Connection( From 141174739bcf6d392953c96d0ab447a18f53e5a6 Mon Sep 17 00:00:00 2001 From: Anson Date: Tue, 1 Oct 2024 13:55:30 +0100 Subject: [PATCH 2/3] Update packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js Co-authored-by: Wyatt Barnes Signed-off-by: Anson --- .../src/lib/solana/signTransactionWithSolanaEncryptedKey.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js b/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js index b9c48ee572..7757c8a4ed 100644 --- a/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js +++ b/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js @@ -6,7 +6,6 @@ const { } = require('@solana/web3.js'); const { removeSaltFromDecryptedKey } = require('../utils'); -const { bs58 } = require('bs58'); /** * From b1fd6d733e56cbe9762f43115b74806edafb3b6e Mon Sep 17 00:00:00 2001 From: Anson Date: Tue, 1 Oct 2024 13:55:43 +0100 Subject: [PATCH 3/3] Update packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js Co-authored-by: Wyatt Barnes Signed-off-by: Anson --- .../src/lib/solana/signTransactionWithSolanaEncryptedKey.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js b/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js index 7757c8a4ed..25cd879464 100644 --- a/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js +++ b/packages/wrapped-keys-lit-actions/src/lib/solana/signTransactionWithSolanaEncryptedKey.js @@ -80,7 +80,7 @@ const { removeSaltFromDecryptedKey } = require('../utils'); ); transaction.sign(solanaKeyPair); - const signature = bs58.encode(transaction.signature); + const signature = ethers.utils.base58.encode(transaction.signature); if (broadcast) { const solanaConnection = new Connection(