Skip to content

Conversation

@joshLong145
Copy link

@joshLong145 joshLong145 commented Oct 15, 2024

testing new container with snapshot in ci

Snap shots now load and work, speeding up ci. but volume is still needed for an unknown reason see pr: https://github.com/LIT-Protocol/lit-assets/pull/1518

This pr removes the need to run npm install within iit-assets/blockchain/contracts and removes the deployment step replaced with loading state from snapshot.

@joshLong145 joshLong145 requested a review from Ansonhkg as a code owner October 15, 2024 18:15
Ansonhkg

This comment was marked as resolved.

@Ansonhkg Ansonhkg self-requested a review October 17, 2024 13:39
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the volume a blocker to getting this PR merged?

@joshLong145
Copy link
Author

Is the volume a blocker to getting this PR merged?

The container used in this PR was published as a test. But does provide some improvements to CI times as you no longer need to install modules for lit assets. The test container was published to a tag so it should persist if you want to merge this pr as is, if not can be closed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Josh Long seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Ansonhkg Ansonhkg added the CI label Aug 13, 2025
@Ansonhkg Ansonhkg closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants