Fix/naga branch trigger #938
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a workflow trigger issue by changing the release workflow to checkout from the branch name instead of a specific SHA, ensuring the workflow runs against the latest branch tip that contains the .changeset files.
Key changes:
- Modified release workflow checkout reference to use branch name instead of SHA
- Added a new Naga health check workflow for monitoring network health
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Updated checkout reference from SHA to branch name to include latest changes |
| .github/workflows/naga-health-check.yml | Added new workflow for automated health monitoring of Naga networks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| workflow_dispatch: | ||
| inputs: | ||
| naga_branch: | ||
| description: 'Branch to run health checks from (optional)' |
There was a problem hiding this comment.
The input parameter 'naga_branch' is marked as required but described as optional. Either set required to false or update the description to remove '(optional)'.
| description: 'Branch to run health checks from (optional)' | |
| description: 'Branch to run health checks from' |
| - name: Health check summary | ||
| if: always() | ||
| run: | | ||
| if [ ${{ job.status }} == 'success' ]; then | ||
| echo "✅ Health check passed for ${{ matrix.network }}" | ||
| echo "Time: $(date -u +"%Y-%m-%d %H:%M:%S UTC")" | ||
| else | ||
| echo "❌ Health check failed for ${{ matrix.network }}" | ||
| echo "Time: $(date -u +"%Y-%m-%d %H:%M:%S UTC")" | ||
| echo "Please check the logs above for details" | ||
|
|
There was a problem hiding this comment.
The job.status context is not available in step conditionals. Use success() or failure() functions instead: if success(); then
| - name: Health check summary | |
| if: always() | |
| run: | | |
| if [ ${{ job.status }} == 'success' ]; then | |
| echo "✅ Health check passed for ${{ matrix.network }}" | |
| echo "Time: $(date -u +"%Y-%m-%d %H:%M:%S UTC")" | |
| else | |
| echo "❌ Health check failed for ${{ matrix.network }}" | |
| echo "Time: $(date -u +"%Y-%m-%d %H:%M:%S UTC")" | |
| echo "Please check the logs above for details" | |
| - name: Health check summary (success) | |
| if: success() | |
| run: | | |
| echo "✅ Health check passed for ${{ matrix.network }}" | |
| echo "Time: $(date -u +"%Y-%m-%d %H:%M:%S UTC")" | |
| - name: Health check summary (failure) | |
| if: failure() | |
| run: | | |
| echo "❌ Health check failed for ${{ matrix.network }}" | |
| echo "Time: $(date -u +"%Y-%m-%d %H:%M:%S UTC")" | |
| echo "Please check the logs above for details" |
WHAT
Change release workflow checkout from tested SHA to branch name (workflow_run.head_branch) so the job runs against the branch tip that contains .changeset.