ci(release): fix Changesets reset by using head_sha and naga tip #941
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Changesets reset issues in the CI release workflow by using exact commit references and adding branch management steps.
- Removes repository name check from the workflow condition
- Changes checkout reference from head branch name to head SHA for exact commit targeting
- Replaces debug output step with enhanced diagnostics and adds failure diagnostics
- Adds branch reset logic to clean up existing changeset release branches
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| echo "Resolved branch tip SHA: $TIP_SHA" | ||
| echo "sha=$TIP_SHA" >> "$GITHUB_OUTPUT" | ||
| - name: Reset release branch base |
There was a problem hiding this comment.
The step name 'Reset release branch base' is misleading as the step actually deletes a remote changeset release branch. Consider renaming to 'Clean up existing changeset release branch' or 'Delete previous changeset release branch' for clarity.
| - name: Reset release branch base | |
| - name: Delete previous changeset release branch |
| version: pnpm changeset version | ||
| publish: pnpm changeset publish --access public | ||
| commit: 'chore(release): version packages' | ||
| title: 'chore(release): version packages' |
There was a problem hiding this comment.
The new commitMode: github parameter should be documented with a comment explaining why this mode is used instead of the default, especially in the context of fixing the Changesets reset issue mentioned in the PR title.
| title: 'chore(release): version packages' | |
| title: 'chore(release): version packages' | |
| # Use commitMode: github to avoid Changesets reset issue (see PR title for context). |
WHAT
Checkout exact workflow_run commit via head_sha