Set a default realm to request_to_join, if a realm id isn't found. (#103)

* Set a default realm to request_to_join, if a realm id isn't found.

* cargo fmt  !

* remove trace & add call.

* Update rust/lit-node/lit-node/tests/toxiproxy/chain_faults.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Spelling.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: GTC6244

rust/lit-node/lit-node/src/peers/peer_state/chain_update.rs

@@ -192,8 +192,43 @@ impl PeerState {
 
     #[instrument(level = "debug", skip_all)]
     pub async fn request_to_join(&self) -> Result<()> {
-        let Some(realm_id) = self.chain_data_config_manager.get_realm_id() else {
-            return Err(unexpected_err("No realm id set", None));
+        let realm_id = match self.chain_data_config_manager.get_realm_id() {
+            Some(realm_id) => realm_id,
+            None => {
+                trace!(
+                    "Failed to get realm id, but will try to join realm # 1, if staking amount is sufficient."
+                );
+
+                let check_staking_amounts = self
+                    .staking_contract
+                    .check_staking_amounts(self.staker_address)
+                    .call()
+                    .await;
+                match check_staking_amounts {
+                    Ok(true) => {
+                        trace!(
+                            "Staking amount is valid for a node to join a network.  Selecting realm # 1."
+                        );
+                    }
+                    Ok(false) => {
+                        return Err(unexpected_err(
+                            "Staking amount is not valid for this node to request to join."
+                                .to_string(),
+                            None,
+                        ));
+                    }
+                    Err(e) => {
+                        return Err(blockchain_err(
+                            e,
+                            Some(
+                                "Failed to check staking amount for this request to join."
+                                    .to_string(),
+                            ),
+                        ));
+                    }
+                }
+                U256::from(1)
+            }
         };
 
         let func = self

rust/lit-node/lit-node/tests/common/faults.rs

@@ -566,7 +566,7 @@ pub fn enable_fault_channel_direct(source_url: Url, target_url: Url, target_is_c
         assert!(get_proxy_result.is_ok());
         let r = get_proxy_result.as_ref().unwrap().enable();
         assert!(r.is_ok());
-        info!("Enabled fault for {:?}", proxy_name);
+        info!("Enabled fault channel for {:?}", proxy_name);
     })
     .join()
     .expect("Failed to enable fault");

rust/lit-node/lit-node/tests/toxiproxy/chain_faults.rs

@@ -6,6 +6,7 @@ use crate::common::setup_logging;
 use ethers::types::U256;
 use lit_node_common::proxy_mapping::ClientProxyMapping;
 use lit_node_testnet::TestSetupBuilder;
+use lit_node_testnet::testnet::actions::Actions;
 use once_cell::sync::Lazy;
 use tracing::info;
 
@@ -82,7 +83,6 @@ async fn auto_rejoin_faulty_node() {
 
     info!("TEST: auto_rejoin_faulty_node");
     let realm_id = U256::from(1);
-    let seconds_to_increase = 300;
 
     // Start a new node collection
     let (testnet, _validator_collection, _end_user) = TestSetupBuilder::default()
@@ -93,9 +93,12 @@ async fn auto_rejoin_faulty_node() {
 
     let actions = testnet.actions().clone();
 
-    // wait for a few seconds to led the nodes chat with each other.
+    // wait for a few seconds to let the nodes chat with each other.
     actions.sleep_millis(1000).await;
 
+    // Advance and check the current and next validators.
+    advance_and_check_current_and_next_validators(&actions, realm_id).await;
+
     let faulty_node_port =
         disable_chain_for_random_faulty_node(STARTING_PORT, FAULT_TEST_NUM_NODES);
     info!("Faulty node port: {}", faulty_node_port);
@@ -108,23 +111,31 @@ async fn auto_rejoin_faulty_node() {
     );
 
     // Update the epoch, forcing a kick due to DKG non-participation.
-    let epoch = actions.get_current_epoch(realm_id).await;
-    info!("Current epoch: {}", epoch);
-    actions
-        .increase_blockchain_timestamp(seconds_to_increase)
-        .await;
+    advance_and_check_current_and_next_validators(&actions, realm_id).await;
 
-    let next_epoch = epoch + U256::from(1);
-    info!("Next epoch: {}", next_epoch);
-    actions.wait_for_epoch(realm_id, next_epoch).await;
-    info!("Advanced to next epoch: {}", next_epoch);
+    // advance again
+    advance_and_check_current_and_next_validators(&actions, realm_id).await;
 
     // Test to see if our validator was kicked.
 
-    // wait for the kicked node to try to call rejion.
+    // wait for the kicked node to try to call request_to_join.
     enable_chain_for_node(faulty_node_port);
     actions.sleep_millis(3000).await;
 
+    advance_and_check_current_and_next_validators(&actions, realm_id).await;
+}
+
+async fn advance_and_check_current_and_next_validators(actions: &Actions, realm_id: U256) {
+    let seconds_to_increase = 300;
+
+    let validator_structs = actions.get_current_validator_structs(realm_id).await;
+    let next_validator_structs = actions.get_next_validator_structs(realm_id).await;
+    info!(
+        "Current/next validator count before advance: {} / {}",
+        validator_structs.len(),
+        next_validator_structs.len()
+    );
+
     let epoch = actions.get_current_epoch(realm_id).await;
     info!("Current epoch: {}", epoch);
     actions
@@ -135,4 +146,12 @@ async fn auto_rejoin_faulty_node() {
     info!("Next epoch: {}", next_epoch);
     actions.wait_for_epoch(realm_id, next_epoch).await;
     info!("Advanced to next epoch: {}", next_epoch);
+
+    let validator_structs = actions.get_current_validator_structs(realm_id).await;
+    let next_validator_structs = actions.get_next_validator_structs(realm_id).await;
+    info!(
+        "Current/next validator count after advance: {} / {}",
+        validator_structs.len(),
+        next_validator_structs.len()
+    );
 }