Skip to content

Commit 2131b40

Browse files
committed
Fix Tests
1 parent 43f730d commit 2131b40

File tree

7 files changed

+24
-12
lines changed

7 files changed

+24
-12
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# Changelog
22
## master
33
+ Add `httpClient`-Method to `LKDev\HetznerCloud\HetznerAPIClient`
4-
+ Remove the `backup_window`-Property from the `enableBackups`-Method in the Class `LKDev\HetznerCloud\Models\Servers`
54
+ Add `labels`-Property to `LKDev\HetznerCloud\Models\FloatingIp\FloatingIP`
65
+ Add `labels`-Property to `LKDev\HetznerCloud\Models\Server\Server`
76
+ Add `labels`-Property to `LKDev\HetznerCloud\Models\Image\Image`

src/Models/ISOs/ISOs.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class ISOs extends Model
2727
* @return array
2828
* @throws \LKDev\HetznerCloud\APIException
2929
*/
30-
public function all(RequestOpts $requestOpts): array
30+
public function all(RequestOpts $requestOpts = null): array
3131
{
3232
if ($requestOpts == null) {
3333
$requestOpts = new RequestOpts();

src/Models/Images/Image.php

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,20 @@ public function __construct(
161161
*/
162162
public function update(string $description = null, string $type = null, array $labels = null): Image
163163
{
164+
$params = [];
165+
if ($description != null) {
166+
$params['description'] = $description;
167+
}
168+
169+
if ($type != null) {
170+
$params['type'] = $type;
171+
}
172+
173+
if ($labels != null) {
174+
$params['labels'] = $labels;
175+
}
164176
$response = $this->httpClient->put('images/' . $this->id, [
165-
'json' => [
166-
'description' => $description == null ? $this->description : $type,
167-
'type' => $type == null ? $this->type : $type,
168-
'labels' => $labels == null ? $this->labels : $labels,
169-
],
177+
'json' => $params,
170178
]);
171179
if (!HetznerAPIClient::hasError($response)) {
172180
return self::parse(json_decode((string)$response->getBody())->image);

src/Models/Prices/Prices.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class Prices extends Model
3131
* @return \stdClass
3232
* @throws \LKDev\HetznerCloud\APIException
3333
*/
34-
public function all(RequestOpts $requestOpts): \stdClass
34+
public function all(RequestOpts $requestOpts = null): \stdClass
3535
{
3636
if ($requestOpts == null) {
3737
$requestOpts = new RequestOpts();

src/Models/Servers/Server.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -379,12 +379,17 @@ public function changeType(ServerType $serverType, bool $upgradeDisk = false): A
379379
* Enables and configures the automatic daily backup option for the server. Enabling automatic backups will increase the price of the server by 20%
380380
*
381381
* @see https://docs.hetzner.cloud/#resources-server-actions-post-11
382+
* @param string|null $backupWindow
382383
* @return APIResponse
383384
* @throws \LKDev\HetznerCloud\APIException
384385
*/
385-
public function enableBackups(): APIResponse
386+
public function enableBackups(string $backupWindow = null): APIResponse
386387
{
387-
$response = $this->httpClient->post($this->replaceServerIdInUri('servers/{id}/actions/enable_backup'));
388+
$response = $this->httpClient->post($this->replaceServerIdInUri('servers/{id}/actions/enable_backup'), [
389+
'json' => [
390+
'backup_window' => $backupWindow,
391+
],
392+
]);
388393
if (!HetznerAPIClient::hasError($response)) {
389394
return APIResponse::create([
390395
'action' => Action::parse(json_decode((string)$response->getBody())->action)

src/Models/Servers/Types/ServerTypes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class ServerTypes extends Model
2727
* @return array
2828
* @throws \LKDev\HetznerCloud\APIException
2929
*/
30-
public function all(RequestOpts $requestOpts): array
30+
public function all(RequestOpts $requestOpts = null): array
3131
{
3232
if ($requestOpts == null) {
3333
$requestOpts = new RequestOpts();

tests/Unit/Servers/ServerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ public function testPowerOn()
158158

159159
public function testEnableBackups()
160160
{
161-
$apiResponse = $this->server->enableBackups();
161+
$apiResponse = $this->server->enableBackups('22-02');
162162
$this->assertEquals('enable_backup', $apiResponse->getResponsePart('action')->command);
163163
$this->assertEquals($this->server->id, $apiResponse->getResponsePart('action')->resources[0]->id);
164164
$this->assertEquals('server', $apiResponse->getResponsePart('action')->resources[0]->type);

0 commit comments

Comments
 (0)