Fix Placement Group Tests

Author: LKaemmerling

src/Models/PlacementGroups/PlacementGroups.php

@@ -20,9 +20,9 @@ class PlacementGroups extends Model implements Resources
     protected $placement_groups;
 
     /**
-     * Returns all existing placementGroup objects.
+     * Returns all existing PlacementGroup objects.
      *
-     * @see https://docs.hetzner.cloud/#placement-groups-get-all-placementgroups
+     * @see https://docs.hetzner.cloud/#placement-groups-get-all-PlacementGroups
      *
      * @param  RequestOpts|null  $requestOpts
      * @return array
@@ -41,7 +41,7 @@ public function all(?RequestOpts $requestOpts = null): array
     /**
      * Returns all existing PlacementGroup objects.
      *
-     * @see https://docs.hetzner.cloud/#placement-groups-get-all-placementgroups
+     * @see https://docs.hetzner.cloud/#placement-groups-get-all-PlacementGroups
      *
      * @param  RequestOpts|null  $requestOpts
      * @return APIResponse|null
@@ -69,27 +69,27 @@ public function list(?RequestOpts $requestOpts = null): ?APIResponse
     /**
      * Returns a specific PlacementGroup object. The PlacementGroup must exist inside the project.
      *
-     * @see https://docs.hetzner.cloud/#placement-groups-get-a-placementgroup
+     * @see https://docs.hetzner.cloud/#placement-groups-get-a-PlacementGroup
      *
-     * @param  int  $serverId
-     * @return PlacementGroup
+     * @param  int  $placementGroupId
+     * @return ?PlacementGroup
      *
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getById(int $serverId): ?PlacementGroup
+    public function getById(int $placementGroupId): ?PlacementGroup
     {
-        $response = $this->httpClient->get('placement_group/'.$serverId);
+        $response = $this->httpClient->get('placement_group/'.$placementGroupId);
         if (! HetznerAPIClient::hasError($response)) {
-            return PlacementGroup::parse(json_decode((string) $response->getBody())->network);
+            return PlacementGroup::parse(json_decode((string) $response->getBody())->placement_group);
         }
 
         return null;
     }
 
     /**
-     * Returns a specific placementGroup object by its name. The placementGroup must exist inside the project.
+     * Returns a specific PlacementGroup object by its name. The PlacementGroup must exist inside the project.
      *
-     * @see https://docs.hetzner.cloud/#placement-groups-get-all-placementgroups
+     * @see https://docs.hetzner.cloud/#placement-groups
      *
      * @param  string  $name
      * @return PlacementGroup|null
@@ -124,6 +124,9 @@ public function setAdditionalData($input)
      * @param  string  $name
      * @param  string  $type
      * @param  array  $labels
+     *
+     * @return ?APIResponse
+     * @throws \LKDev\HetznerCloud\APIException|\GuzzleHttp\Exception\GuzzleException
      */
     public function create(string $name, string $type, array $labels = [])
     {
@@ -145,6 +148,7 @@ public function create(string $name, string $type, array $labels = [])
                 'placement_group' => PlacementGroup::parse($payload->placement_group),
             ], $response->getHeaders());
         }
+        return null;
     }
 
     /**
@@ -161,6 +165,6 @@ public static function parse($input)
      */
     public function _getKeys(): array
     {
-        return ['one' => 'placementgroup', 'many' => 'placementgroups'];
+        return ['one' => 'placement_group', 'many' => 'placement_groups'];
     }
 }

tests/Unit/Models/PlacementGroups/PlacementGroupTest.php

@@ -19,6 +19,6 @@ public function setUp(): void
         parent::setUp();
         $tmp = new PlacementGroups($this->hetznerApi->getHttpClient());
         $this->mockHandler->append(new Response(200, [], file_get_contents(__DIR__.'/fixtures/placement_group.json')));
-        $this->network = $tmp->get(4711);
+        $this->placement_group = $tmp->get(4862);
     }
 }

tests/Unit/Models/PlacementGroups/PlacementGroupsTest.php

@@ -55,7 +55,7 @@ public function testGetByName()
     {
         $this->mockHandler->append(new Response(200, [], file_get_contents(__DIR__.'/fixtures/placement_groups.json')));
         $placement_group = $this->placement_groups->getByName('my_placemengroup');
-        $this->assertEquals(4711, $placement_group->id);
+        $this->assertEquals(4862, $placement_group->id);
         $this->assertEquals('my_placemengroup', $placement_group->name);
 
         $this->assertCount(1, $placement_group->servers);
@@ -72,8 +72,9 @@ public function testGetByName()
     public function testGet()
     {
         $this->mockHandler->append(new Response(200, [], file_get_contents(__DIR__.'/fixtures/placement_group.json')));
-        $placement_group = $this->placement_groups->get(4711);
-        $this->assertEquals(4711, $placement_group->id);
+        $placement_group = $this->placement_groups->get(4862);
+
+        $this->assertEquals(4862, $placement_group->id);
         $this->assertEquals('my_placemengroup', $placement_group->name);
 
         $this->assertCount(1, $placement_group->servers);