Improve test coverage

LKaemmerling · LKaemmerling · commit 81ff30a0439b · 2019-05-23T08:10:20.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## master (XX.XX.XXXX)
  + Add `automount` and `format` Parameters to `LKDev\HetznerCloud\Models\Volumes\Volumes` - `create`
  + Add `created` property to `LKDev\HetznerCloud\Models\FloatingIps\FloatingIp`
+ + Improve test coverage
 
 ## 1.6.0 (08.05.2019)
 + Setting the UserAgent is now possible with `LKDev\HetznerCloud\HetznerAPIClient` - `setUserAgent()`
diff --git a/src/Models/Locations/Location.php b/src/Models/Locations/Location.php
@@ -64,11 +64,11 @@ class Location extends Model
     public function __construct(
         int $id,
         string $name,
-        string $description,
-        string $country,
-        string $city,
-        float $latitude,
-        float $longitude
+        string $description=null,
+        string $country=null,
+        string $city=null,
+        float $latitude=null,
+        float $longitude=null
     ) {
         $this->id = $id;
         $this->name = $name;
@@ -91,4 +91,4 @@ public static function parse($input)
         }
         return new self($input->id, $input->name, $input->description, $input->country, $input->city, $input->latitude, $input->longitude);
     }
-}
+}
diff --git a/tests/Integration/ApiResponseTest.php b/tests/Integration/ApiResponseTest.php
@@ -6,7 +6,7 @@
  * Time: 14:35
  */
 
-namespace Tests\Unit;
+namespace Tests\Integration;
 
 use LKDev\HetznerCloud\APIResponse;
 use PHPUnit\Framework\TestCase;
diff --git a/tests/Integration/BasicClientTest.php b/tests/Integration/BasicClientTest.php
diff --git a/tests/Integration/Datacenters/DatacentersTest.php b/tests/Integration/Datacenters/DatacentersTest.php
@@ -6,7 +6,7 @@
  * Time: 18:31
  */
 
-namespace Tests\Unit;
+namespace Tests\Integration;
 
 use LKDev\HetznerCloud\Models\Datacenters\Datacenters;
 use Tests\TestCase;
diff --git a/tests/Integration/FloatingIPs/FloatingIPsTest.php b/tests/Integration/FloatingIPs/FloatingIPsTest.php
@@ -6,7 +6,7 @@
  * Time: 18:31
  */
 
-namespace Tests\Unit\FloatingIPs;
+namespace Tests\Integration\FloatingIPs;
 
 use LKDev\HetznerCloud\Models\Datacenters\Datacenters;
 use LKDev\HetznerCloud\Models\FloatingIps\FloatingIps;
diff --git a/tests/Integration/FloatingIPs/FloatingIpTest.php b/tests/Integration/FloatingIPs/FloatingIpTest.php
@@ -6,7 +6,7 @@
  * Time: 07:58
  */
 
-namespace Tests\Unit\FloatingIPs;
+namespace Tests\Integration\FloatingIPs;
 
 use LKDev\HetznerCloud\Models\FloatingIps\FloatingIp;
 use LKDev\HetznerCloud\Models\FloatingIps\FloatingIps;
diff --git a/tests/Integration/ISO/ISOsTest.php b/tests/Integration/ISO/ISOsTest.php
@@ -6,7 +6,7 @@
  * Time: 18:31
  */
 
-namespace Tests\Unit;
+namespace Tests\Integration;
 
 use LKDev\HetznerCloud\Models\Datacenters\Datacenters;
 use LKDev\HetznerCloud\Models\ISOs\ISOs;
diff --git a/tests/Integration/Images/ImagesTest.php b/tests/Integration/Images/ImagesTest.php
@@ -6,7 +6,7 @@
  * Time: 18:31
  */
 
-namespace Tests\Unit;
+namespace Tests\Integration;
 
 use LKDev\HetznerCloud\Models\Datacenters\Datacenters;
 use LKDev\HetznerCloud\Models\Images\Images;
diff --git a/tests/Integration/Locations/LocationsTest.php b/tests/Integration/Locations/LocationsTest.php
@@ -6,7 +6,7 @@
  * Time: 18:31
  */
 
-namespace Tests\Unit;
+namespace Tests\Integration;
 
 use LKDev\HetznerCloud\Models\Datacenters\Datacenters;
 use LKDev\HetznerCloud\Models\Locations\Locations;
diff --git a/tests/Integration/Pricing/PricingTest.php b/tests/Integration/Pricing/PricingTest.php
@@ -6,7 +6,7 @@
  * Time: 18:31
  */
 
-namespace Tests\Unit;
+namespace Tests\Integration;
 
 use LKDev\HetznerCloud\Models\Datacenters\Datacenters;
 use LKDev\HetznerCloud\Models\Prices\Prices;
diff --git a/tests/Integration/ServerTypes/ServerTypesTest.php b/tests/Integration/ServerTypes/ServerTypesTest.php
@@ -6,7 +6,7 @@
  * Time: 18:31
  */
 
-namespace Tests\Unit;
+namespace Tests\Integration;
 
 use LKDev\HetznerCloud\Models\Datacenters\Datacenters;
 use LKDev\HetznerCloud\Models\Locations\Locations;
diff --git a/tests/Integration/Servers/ServerTest.php b/tests/Integration/Servers/ServerTest.php
@@ -6,7 +6,7 @@
  * Time: 19:51
  */
 
-namespace Tests\Unit\Servers;
+namespace Tests\Integration\Servers;
 
 use LKDev\HetznerCloud\Models\Images\Image;
 use LKDev\HetznerCloud\Models\ISOs\ISO;
diff --git a/tests/Integration/Servers/ServersTest.php b/tests/Integration/Servers/ServersTest.php
@@ -6,7 +6,7 @@
  * Time: 18:31
  */
 
-namespace Tests\Unit\Servers;
+namespace Tests\Integration\Servers;
 
 use LKDev\HetznerCloud\Models\Servers\ServerRequestOpts;
 use LKDev\HetznerCloud\Models\Servers\Servers;
diff --git a/tests/Integration/Volumes/VolumeTest.php b/tests/Integration/Volumes/VolumeTest.php
@@ -0,0 +1,67 @@
+<?php
+
+namespace Tests\Integration\Volumes;
+
+use LKDev\HetznerCloud\Models\FloatingIps\FloatingIp;
+use LKDev\HetznerCloud\Models\FloatingIps\FloatingIps;
+use LKDev\HetznerCloud\Models\Servers\Server;
+use LKDev\HetznerCloud\Models\Volumes\Volume;
+use LKDev\HetznerCloud\Models\Volumes\Volumes;
+use Tests\TestCase;
+
+
+class VolumeTest extends TestCase
+{
+
+    /**
+     * @var Volume
+     */
+    protected $volume;
+
+    /**
+     *
+     */
+    public function setUp()
+    {
+        parent::setUp();
+        $tmp = new Volumes($this->hetznerApi->getHttpClient());
+
+        $this->volume = $tmp->get(4711);
+    }
+
+    public function testAttach()
+    {
+        $resp = $this->volume->attach(new Server(43), false);
+        $this->assertEquals('attach_volume', $resp->getResponsePart('action')->command);
+    }
+
+    public function testDelete()
+    {
+        $resp = $this->volume->delete();
+        $this->assertEmpty($resp->getResponse());
+    }
+
+    public function testUpdate()
+    {
+        $resp = $this->volume->update(["name" => "new-name"]);
+        $this->assertEquals("new-name", $resp->getResponsePart("volume")->name);
+    }
+
+    public function testChangeProtection()
+    {
+        $apiResponse = $this->volume->changeProtection();
+        $this->assertEquals('change_protection', $apiResponse->getResponsePart('action')->command);
+    }
+
+    public function testResize()
+    {
+        $resp = $this->volume->resize(50);
+        $this->assertEquals('resize_volume', $resp->getResponsePart('action')->command);
+    }
+
+    public function testDetach()
+    {
+        $resp = $this->volume->detach();
+        $this->assertEquals('detach_volume', $resp->getResponsePart('action')->command);
+    }
+}
diff --git a/tests/Integration/Volumes/VolumesTest.php b/tests/Integration/Volumes/VolumesTest.php
@@ -0,0 +1,64 @@
+<?php
+
+namespace Tests\Integration\Volumes;
+
+use LKDev\HetznerCloud\Models\Locations\Location;
+use LKDev\HetznerCloud\Models\Volumes\Volumes;
+use Tests\TestCase;
+
+class VolumesTest extends TestCase
+{
+    /**
+     * @var Volumes
+     */
+    protected $volumes;
+
+    /**
+     *
+     */
+    public function setUp()
+    {
+        parent::setUp();
+        $this->volumes = new Volumes($this->hetznerApi->getHttpClient());
+    }
+
+    public function testCreate()
+    {
+        $resp = $this->volumes->create("database-storage", 42, null, new Location(1, "nbg1"));
+
+        $volume = $resp->getResponsePart("volume");
+        $this->assertEquals($volume->id, 4711);
+        $this->assertEquals($volume->name, "database-storage");
+        $this->assertEquals($volume->server, 12);
+        $this->assertEquals($volume->location->id, 1);
+    }
+
+    public function testGetByName()
+    {
+        $volume = $this->volumes->getByName("database-storage");
+        $this->assertEquals($volume->id, 4711);
+        $this->assertEquals($volume->name, "database-storage");
+        $this->assertEquals($volume->server, 12);
+        $this->assertEquals($volume->location->id, 1);
+    }
+
+    public function testGet()
+    {
+        $volume = $this->volumes->get(4711);
+        $this->assertEquals($volume->id, 4711);
+        $this->assertEquals($volume->name, "database-storage");
+        $this->assertEquals($volume->server, 12);
+        $this->assertEquals($volume->location->id, 1);
+    }
+
+    public function testAll()
+    {
+        $volumes = $this->volumes->all();
+        $this->assertCount(1, $volumes);
+        $volume = $volumes[0];
+        $this->assertEquals($volume->id, 4711);
+        $this->assertEquals($volume->name, "database-storage");
+        $this->assertEquals($volume->server, 12);
+        $this->assertEquals($volume->location->id, 1);
+    }
+}
diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -26,6 +26,6 @@ abstract class TestCase extends \PHPUnit\Framework\TestCase
      */
     public function setUp()
     {
-        $this->hetznerApi = new HetznerAPIClient('abcdef', 'http://localhost:4000/v1/');
+        $this->hetznerApi = new HetznerAPIClient('abcdef', 'http://localhost:8080/v1/');
     }
 }
