Skip to content

Commit aec81bb

Browse files
JubekiLKaemmerling
authored andcommitted
Fix nullable type declarations
1 parent 4e6e2e4 commit aec81bb

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+111
-111
lines changed

composer.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/APIException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class APIException extends \Exception
1717
* @param int $code
1818
* @param \Throwable|null $previous
1919
*/
20-
public function __construct(APIResponse $response, string $message = '', int $code = 0, \Throwable $previous = null)
20+
public function __construct(APIResponse $response, string $message = '', int $code = 0, ?\Throwable $previous = null)
2121
{
2222
$this->response = $response;
2323
parent::__construct($message, $code, $previous);

src/APIResponse.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function getResponse(): array
3636
* @param string|null $resource
3737
* @return Model|string|bool
3838
*/
39-
public function getResponsePart(string $resource = null)
39+
public function getResponsePart(?string $resource = null)
4040
{
4141
return (array_key_exists($resource, $this->response)) ? $this->response[$resource] : false;
4242
}

src/Models/Actions/Action.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public function __construct(
6767
int $progress,
6868
string $status,
6969
string $started,
70-
string $finished = null,
70+
?string $finished = null,
7171
$resources = null,
7272
$error = null
7373
) {

src/Models/Actions/ActionRequestOpts.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class ActionRequestOpts extends RequestOpts
3030
* @param $page
3131
* @param $labelSelector
3232
*/
33-
public function __construct(string $status = null, string $sort = null, int $perPage = null, int $page = null, string $labelSelector = null)
33+
public function __construct(?string $status = null, ?string $sort = null, ?int $perPage = null, ?int $page = null, ?string $labelSelector = null)
3434
{
3535
parent::__construct($perPage, $page, $labelSelector);
3636
$this->status = $status;

src/Models/Actions/Actions.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class Actions extends Model implements Resources
2020
*/
2121
protected $actions;
2222

23-
public function all(RequestOpts $requestOpts = null): array
23+
public function all(?RequestOpts $requestOpts = null): array
2424
{
2525
if ($requestOpts == null) {
2626
$requestOpts = new RequestOpts();
@@ -35,7 +35,7 @@ public function all(RequestOpts $requestOpts = null): array
3535
*
3636
* @throws \LKDev\HetznerCloud\APIException
3737
*/
38-
public function list(RequestOpts $requestOpts = null): ?APIResponse
38+
public function list(?RequestOpts $requestOpts = null): ?APIResponse
3939
{
4040
if ($requestOpts == null) {
4141
$requestOpts = new RequestOpts();

src/Models/Certificates/Certificate.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class Certificate extends Model implements Resource
7171
* @param array|null $used_by
7272
* @param array|null $labels
7373
*/
74-
public function __construct(int $id, string $name = null, string $certificate = null, string $created = null, string $not_valid_before = null, string $not_valid_after = null, array $domain_names = null, string $fingerprint = null, $used_by = null, $labels = [])
74+
public function __construct(int $id, ?string $name = null, ?string $certificate = null, ?string $created = null, ?string $not_valid_before = null, ?string $not_valid_after = null, ?array $domain_names = null, ?string $fingerprint = null, $used_by = null, $labels = [])
7575
{
7676
$this->id = $id;
7777
$this->name = $name;

src/Models/Certificates/CertificateRequestOpts.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class CertificateRequestOpts extends RequestOpts
2525
* @param $page
2626
* @param $labelSelector
2727
*/
28-
public function __construct(string $name = null, int $perPage = null, int $page = null, string $labelSelector = null)
28+
public function __construct(?string $name = null, ?int $perPage = null, ?int $page = null, ?string $labelSelector = null)
2929
{
3030
parent::__construct($perPage, $page, $labelSelector);
3131
$this->name = $name;

src/Models/Certificates/Certificates.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public function create(
7272
*
7373
* @throws \LKDev\HetznerCloud\APIException
7474
*/
75-
public function all(RequestOpts $requestOpts = null): array
75+
public function all(?RequestOpts $requestOpts = null): array
7676
{
7777
if ($requestOpts == null) {
7878
$requestOpts = new RequestOpts();
@@ -91,7 +91,7 @@ public function all(RequestOpts $requestOpts = null): array
9191
*
9292
* @throws \LKDev\HetznerCloud\APIException
9393
*/
94-
public function list(RequestOpts $requestOpts = null): ?APIResponse
94+
public function list(?RequestOpts $requestOpts = null): ?APIResponse
9595
{
9696
if ($requestOpts == null) {
9797
$requestOpts = new RequestOpts();

src/Models/Contracts/Resources.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
interface Resources
99
{
10-
public function all(RequestOpts $requestOpts = null): array;
10+
public function all(?RequestOpts $requestOpts = null): array;
1111

12-
public function list(RequestOpts $requestOpts = null): ?APIResponse;
12+
public function list(?RequestOpts $requestOpts = null): ?APIResponse;
1313

1414
public function getById(int $id);
1515

0 commit comments

Comments
 (0)