Fix getByName Type error (#53)

Author: LKaemmerling

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## master
 * Make package requirements less strict
+* Bugfix: getByName functions had a wrong return type and failed when a resource was not found by name [#50](https://github.com/LKDevelopment/hetzner-cloud-php-sdk/issues/50)
 
 ## 2.2.0 (22.06.2020)
 * Feature: Allow specifying labels on `createImage`

src/Models/Datacenters/Datacenters.php

@@ -93,7 +93,7 @@ public function getById(int $datacenterId): Datacenter
      * @return \LKDev\HetznerCloud\Models\Datacenters\Datacenter
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getByName(string $name): Datacenter
+    public function getByName(string $name): ?Datacenter
     {
         $resp = $this->list(new DatacenterRequestOpts($name));
 

src/Models/FloatingIps/FloatingIps.php

@@ -91,7 +91,7 @@ public function getById(int $floatingIpId): FloatingIp
      * @return \LKDev\HetznerCloud\Models\FloatingIps\FloatingIp
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getByName(string $name)
+    public function getByName(string $name): ?FloatingIp
     {
         $resp = $this->list(new FloatingIPRequestOpts($name));
 

src/Models/ISOs/ISOs.php

@@ -89,7 +89,7 @@ public function getById(int $isoId): ISO
      * @return \LKDev\HetznerCloud\Models\ISOs\ISO
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getByName(string $name): ISO
+    public function getByName(string $name): ?ISO
     {
         $isos = $this->list(new ISORequestOpts($name));
 

src/Models/Images/Images.php

@@ -1,10 +1,4 @@
 <?php
-/**
- * Created by PhpStorm.
- * User: lukaskammerling
- * Date: 28.01.18
- * Time: 21:01.
- */
 
 namespace LKDev\HetznerCloud\Models\Images;
 
@@ -79,14 +73,14 @@ public function getById(int $imageId): Image
     }
 
     /**
-     * Returns a specific datacenter object by its name.
+     * Returns a specific image object by its name.
      *
-     * @see https://docs.hetzner.cloud/#resources-datacenters-get-1
-     * @param int $datacenterId
-     * @return \LKDev\HetznerCloud\Models\Datacenters\Datacenter
+     * @see https://docs.hetzner.cloud/#resources-images-get-1
+     * @param string $name
+     * @return \LKDev\HetznerCloud\Models\Images\Image|null
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getByName(string $name): Image
+    public function getByName(string $name): ?Image
     {
         $images = $this->list(new ImageRequestOpts($name));
 

src/Models/Locations/Locations.php

@@ -89,7 +89,7 @@ public function getById(int $locationId): Location
      * @return \LKDev\HetznerCloud\Models\Locations\Location
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getByName(string $name): Location
+    public function getByName(string $name): ?Location
     {
         $locations = $this->list(new LocationRequestOpts($name));
 

src/Models/Networks/Networks.php

@@ -86,7 +86,7 @@ public function getById(int $serverId): Network
      * @return Network|null
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getByName(string $name)
+    public function getByName(string $name): ?Network
     {
         $networks = $this->list(new NetworkRequestOpts($name));
 

src/Models/SSHKeys/SSHKeys.php

@@ -135,7 +135,7 @@ public function getById(int $id)
      * @return \LKDev\HetznerCloud\Models\SSHKeys\SSHKey
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getByName(string $name)
+    public function getByName(string $name): ?SSHKey
     {
         $sshKeys = $this->list(new SSHKeyRequestOpts($name));
 

src/Models/Servers/Servers.php

@@ -77,7 +77,7 @@ public function list(RequestOpts $requestOpts = null): APIResponse
      * @return \LKDev\HetznerCloud\Models\Servers\Server|null
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getByName(string $serverName)
+    public function getByName(string $serverName): ?Server
     {
         $servers = $this->list(new ServerRequestOpts($serverName));
 

src/Models/Servers/Types/ServerTypes.php

@@ -79,7 +79,7 @@ public function getById(int $serverTypeId)
      * @return \LKDev\HetznerCloud\Models\Servers\Types\ServerType
      * @throws \LKDev\HetznerCloud\APIException
      */
-    public function getByName(string $name)
+    public function getByName(string $name): ?ServerType
     {
         $serverTypes = $this->list(new ServerTypesRequestOpts($name));