better error Handling

Author: LKaemmerling

src/APIException.php

@@ -12,7 +12,7 @@
 class APIException extends \Exception
 {
     /**
-     * @var \Psr\Http\Message\ResponseInterface
+     * @var ApiResponse
      */
     public $response;
 
@@ -24,7 +24,7 @@ class APIException extends \Exception
      * @param int $code
      * @param \Throwable|null $previous
      */
-    public function __construct(ResponseInterface $response, string $message = "", int $code = 0, \Throwable $previous = null)
+    public function __construct(ApiResponse $response, string $message = "", int $code = 0, \Throwable $previous = null)
     {
         $this->response = $response;
         parent::__construct($message, $code, $previous);

src/HetznerAPIClient.php

@@ -100,9 +100,16 @@ public function getHttpClient(): GuzzleClient
      */
     public static function throwError(ResponseInterface $response)
     {
-        var_dump(json_decode((string)$response->getBody()));
-        die();
-        // throw new APIException($response, ->error->code);
+        $body = (string)$response->getBody();
+        if (strlen($body) > 0) {
+            $error = \GuzzleHttp\json_decode($body);
+            throw new APIException(ApiResponse::create([
+                'error' => $error->error
+            ]), $error->error->message);
+        }
+        throw new APIException(ApiResponse::create([
+            'response' => $response
+        ]), 'The response is not parseable');
     }
 
     /**
@@ -120,13 +127,15 @@ public static function hasError(ResponseInterface $response)
 
         return false;
     }
+
     /**
      * @return Actions
      */
     public function actions()
     {
         return new Actions($this->httpClient);
     }
+
     /**
      * @return Servers
      */
@@ -138,9 +147,11 @@ public function servers()
     /**
      * @return ServerTypes
      */
-    public function serverTypes(){
+    public function serverTypes()
+    {
         return new ServerTypes($this->httpClient);
     }
+
     /**
      * @return Datacenters
      */