feat: add handling of 'LAError.Code.passcodeNotSet' error (#2)

Author: AndriyVasyk

Sources/LocalAuthenticationProvider/LocalAuthenticationError.swift

@@ -28,10 +28,13 @@ import Foundation
 public enum LocalAuthenticationError: Error {
     // MARK: - Error codes for common local authentication errors.
 
-    /// -6
+    /// -5, LAError.Code.passcodeNotSet
+    public static let passcodeNotSet: Int = -5
+    
+    /// -6, LAError.Code.biometryNotAvailable
     public static let denied: Int = -6
 
-    /// -7
+    /// -7, LAError.Code.biometryNotEnrolled
     public static let noBiometricsEnrolled: Int = -7
 
     /// 0
@@ -52,6 +55,9 @@ public enum LocalAuthenticationError: Error {
     /// No fingerprints are enrolled on the device.
     case noFingerprintEnrolled
 
+    /// A passcode isn’t set on the device.
+    case noPasscodeSet
+    
     /// An underlying error occurred.
     ///
     /// - Parameter error: The underlying error.

Sources/LocalAuthenticationProvider/LocalAuthenticationProvider.swift

@@ -70,9 +70,12 @@ public final class LocalAuthenticationProvider: LocalAuthenticationProviderProto
                         logger.error("\(#function) Local Authentication Error: \(error.localizedDescription)")
                         throw LocalAuthenticationError.biometricError
                     }
+                case LocalAuthenticationError.passcodeNotSet:
+                    logger.error("\(#function) Check biometric auth available: \(error.localizedDescription)")
+                    throw LocalAuthenticationError.noPasscodeSet
                 default:
                     logger.error("\(#function) Local Authentication Error: \(error.localizedDescription)")
-                    throw LocalAuthenticationError.biometricError
+                    throw LocalAuthenticationError.error(error)
                 }
             }
             return false

Tests/LocalAuthenticationProviderTests/LocalAuthenticationProviderTests.swift

@@ -26,7 +26,7 @@ import XCTest
 @testable import LocalAuthenticationProvider
 
 final class LocalAuthenticationProviderTests: XCTestCase {
-    func testCanEvaluatePolicyWhenOwnetAuthenticatedWithBiometrics() async throws {
+    func testCanEvaluatePolicyWhenOwnerAuthenticatedWithBiometrics() async throws {
         let context = MockLAContext(canEvaluatePolicies: [.deviceOwnerAuthenticationWithBiometrics])
         let provider = LocalAuthenticationProvider(context: context)
         let checkBiometricsSuccess = try await provider.checkBiometricAvailable()
@@ -58,6 +58,19 @@ final class LocalAuthenticationProviderTests: XCTestCase {
         }
     }
 
+    func testCanEvaluatePolicyWhenPasscodeNotSet() async {
+        let errorCode = LocalAuthenticationError.passcodeNotSet
+        let context = MockLAContext(canEvaluatePolicyError: NSError(domain: "", code: errorCode))
+        let provider = LocalAuthenticationProvider(context: context)
+        do {
+            _ = try await provider.checkBiometricAvailable()
+            XCTFail(".noPasscodeSet error must be thrown")
+        } catch LocalAuthenticationError.noPasscodeSet {
+        } catch {
+            XCTFail("Unexpected error thrown - must be .noPasscodeSet")
+        }
+    }
+    
     func testCanEvaluatePolicyWhenBiometricsIssue() async {
         let errorCode = LocalAuthenticationError.noBiometricsEnrolled
         let context = MockLAContext(canEvaluatePolicyError: NSError(domain: "", code: errorCode))
@@ -99,18 +112,20 @@ final class LocalAuthenticationProviderTests: XCTestCase {
 
     func testCanEvaluatePolicyWhenUnknownError() async {
         let errorCode = LocalAuthenticationError.unknownError
-        let context = MockLAContext(canEvaluatePolicyError: NSError(domain: "", code: errorCode))
+        let expectedError = NSError(domain: "", code: errorCode)
+        let context = MockLAContext(canEvaluatePolicyError: expectedError)
         let provider = LocalAuthenticationProvider(context: context)
         do {
             _ = try await provider.checkBiometricAvailable()
             XCTFail("Error must be thrown")
-        } catch LocalAuthenticationError.biometricError {
+        } catch LocalAuthenticationError.error(let error) {
+            XCTAssertEqual(error as NSError, expectedError)
         } catch {
             XCTFail("Unexpected error thrown")
         }
     }
 
-    func testEvaluatePolicyWhenBiometricsSetSuccesful() async throws {
+    func testEvaluatePolicyWhenBiometricsSetSuccessful() async throws {
         let context = MockLAContext(
             successEvaluatePolicies: [.deviceOwnerAuthenticationWithBiometrics],
             canEvaluatePolicies: [.deviceOwnerAuthenticationWithBiometrics])