Pass Fingerprint by value instead of reference (#239)

Fingerprint is Copy, so it should be passed by value.

Author: LLFourn

schnorr_fun/src/frost/chilldkg/encpedpop.rs

@@ -231,7 +231,7 @@ impl AggKeygenInput {
         let tweak_poly = shared_key.grind_fingerprint::<H>(fingerprint);
         // replace our poly with the one that has the fingerprint
         self.inner.agg_poly = shared_key.point_polynomial()[1..].to_vec();
-        debug_assert!(self.shared_key().check_fingerprint::<H>(&fingerprint));
+        debug_assert!(self.shared_key().check_fingerprint::<H>(fingerprint));
 
         for (share_index, (_encryption_key, encrypted_secret_share)) in &mut self.encrypted_shares {
             // 💡 The share encryption is homomorphic so we can apply the tweak
@@ -557,7 +557,7 @@ mod test {
                 assert_eq!(shared_key.pair_secret_share(*share.secret_share()), Some(share));
             }
 
-            assert!(shared_key.check_fingerprint::<sha2::Sha256>(&fingerprint), "fingerprint was grinded correctly");
+            assert!(shared_key.check_fingerprint::<sha2::Sha256>(fingerprint), "fingerprint was grinded correctly");
         }
     }
 

schnorr_fun/src/frost/shared_key.rs

@@ -195,10 +195,7 @@ impl<T: Normalized, Z: ZeroChoice> SharedKey<T, Z> {
     ///
     /// Returns `true` if all coefficients match the fingerprint pattern, `false`
     /// if any coefficient fails to meet the difficulty requirement.
-    pub fn check_fingerprint<H: crate::fun::hash::Hash32>(
-        &self,
-        fingerprint: &Fingerprint,
-    ) -> bool {
+    pub fn check_fingerprint<H: crate::fun::hash::Hash32>(&self, fingerprint: Fingerprint) -> bool {
         use crate::fun::hash::HashAdd;
 
         // the fingerprint is only placed on the non-constant coefficients so it
@@ -597,7 +594,7 @@ mod test {
 
         // Verify the fingerprint is valid
         assert!(
-            shared_key.check_fingerprint::<sha2::Sha256>(&fingerprint),
+            shared_key.check_fingerprint::<sha2::Sha256>(fingerprint),
             "Grinded fingerprint should be valid"
         );
     }