Merge pull request #234 from LLFourn/none_fingerprint

[❄] Fix Fingerprint::default

Author: nickfarrow

schnorr_fun/src/frost/chilldkg/certpedpop.rs

@@ -576,7 +576,7 @@ mod test {
                 threshold,
                 n_receivers,
                 n_extra_generators,
-                Fingerprint::none(),
+                Fingerprint::NONE,
                 &mut rng
             );
 
@@ -606,7 +606,7 @@ mod test {
             threshold,
             n_receivers,
             n_extra_generators,
-            Fingerprint::none(),
+            Fingerprint::NONE,
             &mut rng,
         );
 

schnorr_fun/src/frost/chilldkg/encpedpop.rs

@@ -530,7 +530,7 @@ mod test {
                 threshold,
                 n_receivers,
                 n_generators,
-                Fingerprint::none(),
+                Fingerprint::NONE,
                 &mut rng,
             );
         }

schnorr_fun/src/frost/mod.rs

@@ -426,12 +426,6 @@ where
 /// A Frost signature share.
 pub type SignatureShare = Scalar<Public, Zero>;
 
-/// The default fingerprint used for share generation in production
-pub const FROST_V0_FINGERPRINT: Fingerprint = Fingerprint {
-    bit_length: 18,
-    tag: "frost-v0",
-};
-
 #[cfg(test)]
 mod test {
 

schnorr_fun/src/frost/shared_key.rs

@@ -455,13 +455,17 @@ pub struct Fingerprint {
 }
 
 impl Fingerprint {
-    /// Creates a fingerprint with no difficulty (no grinding required)
-    pub fn none() -> Self {
-        Self {
-            bit_length: 0,
-            tag: "",
-        }
-    }
+    /// The default fingerprint used for share generation in production
+    pub const FROST_V0: Self = Self {
+        bit_length: 18,
+        tag: "frost-v0",
+    };
+
+    /// a 0-bit fingerprint which means it will have no affect.
+    pub const NONE: Self = Self {
+        bit_length: 0,
+        tag: "",
+    };
 
     /// Count leading zero bits across a byte slice
     pub(crate) fn leading_zero_bits(bytes: &[u8]) -> usize {
@@ -480,10 +484,7 @@ impl Fingerprint {
 
 impl Default for Fingerprint {
     fn default() -> Self {
-        Self {
-            bit_length: 8,
-            tag: "frost-dkg",
-        }
+        Self::FROST_V0
     }
 }
 

schnorr_fun/tests/frost_prop.rs

@@ -31,7 +31,7 @@ proptest! {
 
         // // create some scalar polynomial for each party
         let mut rng = TestRng::deterministic_rng(RngAlgorithm::ChaCha);
-        let (mut shared_key, mut secret_shares) = encpedpop::simulate_keygen(&frost.schnorr, threshold, n_parties, n_parties, Fingerprint::none(), &mut rng);
+        let (mut shared_key, mut secret_shares) = encpedpop::simulate_keygen(&frost.schnorr, threshold, n_parties, n_parties, Fingerprint::NONE, &mut rng);
 
         if let Some(tweak) = add_tweak {
             for secret_share in &mut secret_shares {