Review and process new anchor PRs #137-#143

[raifdmueller]

Overview

We have 7 open PRs from @Nantero1 adding new semantic anchors. Before merging, each needs to be reviewed for quality, structure, and completeness.

Open PRs

PR	Anchor	Category (to verify)
#137	CQRS	Software Architecture?
#138	BDD (Given-When-Then)	Testing & Quality?
#139	YAGNI	Design Principles?
#140	GoF Design Patterns	Design Principles?
#141	Chain of Responsibility	Design Principles?
#142	Test Double (Meszaros)	Testing & Quality?
#143	Event-Driven Architecture	Software Architecture?

Review checklist per PR

• Is it a good semantic anchor? Does it meet our criteria: precise, rich, consistent, attributable? Or is it too broad/generic (e.g. GoF as a whole vs. individual patterns)?
• Structure check: Does the .adoc follow our standard template (Core Concepts, When to Use, Key Proponent, categories, roles)?
• Content quality: Are the descriptions accurate and concise? No fluff?
• German translation: Currently missing for all 7 PRs. Needs .de.adoc files.
• Category assignment: Are the categories correct?
• all-anchors.adoc: Is the entry correctly added?
• catalog.md: Is the skill catalog entry correct?

Open questions

1. Merge first, then fix? Or fix before merge?

   • Pro merge-first: Less work for the contributor, we can batch-fix translations
   • Pro fix-first: Cleaner history, no broken state on main
   • Suggestion: Review content quality and anchor suitability first (reject/request changes if needed), then merge acceptable ones and batch-add translations ourselves.

2. Anchor suitability concerns:

   • GoF Design Patterns (feat: Add GoF Design Patterns semantic anchor #140): Very broad. Is "GoF" a single anchor, or should individual patterns (Strategy, Observer, etc.) be separate anchors? Or is the concept of GoF patterns itself the anchor?
   • Chain of Responsibility (feat: Add Chain of Responsibility semantic anchor #141): Single GoF pattern as anchor. If we accept GoF as a whole, do we also want individual patterns?
   • YAGNI (feat: Add YAGNI semantic anchor #139): Strong candidate, well-known principle. But how does it relate to our existing DRY anchor?

3. Consistency with existing anchors: Do the new ones follow the same depth and style as our existing 48 anchors?

Suggested workflow

1. Review each PR for anchor quality (comment on PR if changes needed)
2. Merge approved PRs one by one
3. Batch-create German translations for all merged anchors
4. Verify website builds correctly after each merge

[raifdmueller]

New Concept: Umbrella Anchors with Sub-Anchors

Based on the GoF discussion (#140 + #141), we're introducing a two-level anchor system:

Level 1: Umbrella Anchors (main catalog)

• Listed in the main catalog and card deck
• Examples: GoF Design Patterns, Fowler Patterns (PEAA)
• Card visually looks like 3 stacked cards behind each other, signaling "there's more inside"

Level 2: Sub-Anchors (linked, optional)

• NOT in the main catalog, but linked from the umbrella anchor page
• Individual patterns (Strategy, Observer, Decorator, Factory Method, etc.)
• Optional expansion card set for the physical deck
• Each has its own .adoc, prompts, and card — but discovered through the umbrella

Why?

Individual GoF patterns DO make strong semantic anchors with useful prompts:

• Strategy: "Extract the varying algorithm into a Strategy pattern so new algorithms need no changes to the context."
• Observer: "Decouple these components using the Observer pattern."
• Decorator: "Add caching via Decorator without modifying the original class."

But 23 individual entries would dilute the main catalog. The umbrella approach keeps the catalog focused while allowing depth.

Consequences for current PRs

• feat: Add GoF Design Patterns semantic anchor #140 GoF Design Patterns: ✅ Merge as umbrella anchor
• feat: Add Chain of Responsibility semantic anchor #141 Chain of Responsibility: ❌ Decline as main anchor, invite resubmission as sub-anchor once the sub-anchor structure is implemented

Open design questions

• How to mark umbrella anchors in .adoc metadata (:type: umbrella?)
• Website UI for browsing sub-anchors (accordion? sub-page?)
• Card design: stacked card visual for umbrella cards
• How does the card reference "23 Pattern Cards" without having generated all of them yet?

[raifdmueller]

All 7 PRs (#137-#143) have been reviewed, merged, and processed:

• All anchors merged to main
• German translations added for all 7 anchors (PR feat: SOLID umbrella, German translations, catalog update #161)
• GoF Design Patterns converted to umbrella with 23 sub-patterns (PR feat: umbrella anchors with GoF sub-patterns #159)
• Chain of Responsibility (feat: Add Chain of Responsibility semantic anchor #141) covered as GoF sub-anchor
• AgentSkill catalog updated with all new entries
• Changelog updated (PR docs: update changelog with umbrella anchors and translations #163)