running synthetic with sharegpt

Author: sammshen

.github/workflows/run_benchmarks_gke.yaml

@@ -91,13 +91,6 @@ jobs:
           echo "✅ Running benchmark script..."
           python run-bench.py
 
-      # eventually we will use /srv/runner-db as a database for the dashboard
-      # results files include TTFT, ITL, and the bench-spec.yaml content that ran the benchmark
-      - name: Save .results files to local DB folder outside workspace
-        run: |
-          find 4-latest-results/ -name '*.results' -exec cp {} ~/srv/runner-db/ \;
-          echo "✅ Saved .results files to ~/srv/runner-db/"
-
       - name: Upload .results artifacts to GitHub
         uses: actions/upload-artifact@v4
         with:

3-workloads/synthetic/run_synthetic.sh

@@ -21,10 +21,10 @@ NUM_ROUNDS=$6
 SYSTEM_PROMPT=$7
 CHAT_HISTORY=$8
 ANSWER_LEN=$9
-USE_SHAREGPT=${10:-false}
+USE_SHAREGPT=$10
 # If QPS values are provided, use them; otherwise use default
-if [ $# -gt 9 ]; then
-    QPS_VALUES=("${@:10}")
+if [ $# -gt 10 ]; then
+    QPS_VALUES=("${@:11}")
 else
     QPS_VALUES=(0.7)  # Default QPS value
 fi
@@ -80,7 +80,7 @@ run_benchmark() {
 # Run benchmarks for each QPS value
 for qps in "${QPS_VALUES[@]}"; do
     run_benchmark "$qps"
-    local output_file="../../4-latest-results/${KEY}_synthetic_output_${qps}.csv"
+    output_file="../../4-latest-results/${KEY}_synthetic_output_${qps}.csv"
     python3 "../../4-latest-results/post-processing/summarize.py" \
         "$output_file" \
         KEY="$KEY" \

4-latest-results/post-processing/summarize.py

@@ -100,9 +100,17 @@ def process_output(filename: str, **kwargs):
             f.write(bench_spec_content)
             f.write("\n===========================================================\n")
 
-    # Add the specific workload that was run (a subset of Workloads in bench-spec.yaml)
     print(f"Performance summary saved to {results_path}")
 
+    # Save a copy of the results file to ~/srv/runner-db/
+    runner_db_path = os.path.expanduser("~/srv/runner-db/")
+    os.makedirs(runner_db_path, exist_ok=True)
+    runner_db_file = os.path.join(runner_db_path, f"{filename_without_parent_or_ext}-{timestamp}.results")
+
+    # Copy the contents to the new location
+    with open(results_path, "r") as src, open(runner_db_file, "w") as dst:
+        dst.write(src.read())
+
 if __name__ == "__main__":
     if len(sys.argv) < 2:
         print("Usage: python summarize.py <path_to_csv> [key=value ...]")