Merge pull request #6800 from AndrewVSutherland/charmodbrowse

Resolves #6680

Author: roed314

lmfdb/characters/main.py

@@ -22,7 +22,6 @@
     WebSmallDirichletGroup,
     WebDBDirichletOrbit
 )
-from lmfdb.characters.ListCharacters import get_character_modulus
 from lmfdb.characters import characters_page
 from lmfdb import db
 
@@ -312,24 +311,6 @@ def dirichlet_character_search(info, query):
 @characters_page.route("/Dirichlet")
 @characters_page.route("/Dirichlet/")
 def render_DirichletNavigation():
-    try:
-        if 'modbrowse' in request.args:
-            arg = request.args['modbrowse']
-            arg = arg.split('-')
-            modulus_start = int(arg[0])
-            modulus_end = int(arg[1])
-            info = {'args': request.args}
-            info['title'] = 'Dirichlet characters of modulus ' + str(modulus_start) + '-' + str(modulus_end)
-            info['bread'] = bread('Modulus')
-            info['learnmore'] = learn()
-            headers, entries, rows, cols = get_character_modulus(modulus_start, modulus_end, limit=8)
-            info['entries'] = entries
-            info['rows'] = list(range(modulus_start, modulus_end + 1))
-            info['cols'] = sorted({r[1] for r in entries})
-            return render_template("ModulusList.html", **info)
-    except (ValueError, IndexError) as err:
-        flash_error("Error raised in parsing: %s", err)
-
     if request.args:
         # hidden_search_type for prev/next buttons
         info = to_dict(request.args, search_array=DirichSearchArray())

lmfdb/characters/templates/CharacterNavigate.html

@@ -12,7 +12,7 @@ <h2> Browse </h2>
 <table class="browse">
   <tr>
     <td>By {{ KNOWL('character.dirichlet.modulus', title="modulus") }}:</td>
-    <td>{% for rnge in info.modulus_list %} <a href="?modbrowse={{rnge}}">{{rnge}}</a>&nbsp;&nbsp; {% endfor %} $\cdots$</td>
+    <td>{% for rnge in info.modulus_list %} <a href="?modulus={{rnge}}">{{rnge}}</a>&nbsp;&nbsp; {% endfor %} $\cdots$</td>
   </tr><tr>
     <td>By {{ KNOWL('character.dirichlet.conductor', title="conductor") }}:</td>
     <td>{% for rnge in info.conductor_list %} <a href="?conductor={{rnge}}">{{rnge}}</a>&nbsp;&nbsp; {% endfor %} $\cdots$</td>

lmfdb/characters/test_characters.py

@@ -31,8 +31,8 @@ def test_even_odd(self):
         assert '>%s</t' % (parity_string(-1)) in W.get_data(as_text=True)
 
     def test_modbrowse(self):
-        W = self.tc.get('/Character/Dirichlet/?modbrowse=41-60')
-        assert 'Dirichlet/45/11' in W.get_data(as_text=True)
+        W = self.tc.get('/Character/Dirichlet/?modulus=41-60')
+        assert '46.d' in W.get_data(as_text=True)
 
     def test_search(self):
         W = self.tc.get('/Character/Dirichlet/?conductor=15&order=4')