Merge pull request #6707 from LMFDB/main

Author: edgarcosta

.devcontainer/devcontainer.json

@@ -8,7 +8,7 @@
   },
   "postCreateCommand": "/bin/bash .devcontainer/setup.sh",
   "postAttachCommand": {
-    "server": "sage -python start-lmfdb.py --debug",
+    "server": "sage -python start-lmfdb.py --debug"
   },
   "forwardPorts": [37777],
   "customizations": {
@@ -25,4 +25,4 @@
       }
     }
   }
-}
+}

.environment.yml

@@ -16,3 +16,4 @@ dependencies:
   - flask
   - werkzeug
   - parallel
+  - pari-elldata

.github/actions/snippet_setup/action.yml

@@ -0,0 +1,71 @@
+name: 'Snippet Setup'
+description: 'Set up LMFDB environment for generating snippets'
+    
+runs:
+  using: 'composite'
+  steps:
+  - uses: actions/checkout@v3
+
+  - uses: conda-incubator/setup-miniconda@v2
+    with:
+      activate-environment: lmfdb
+      auto-activate-base: false
+      # environment-file: .environment.yml # now we install after cache
+      channel-priority: strict
+      # IMPORTANT: use-only-tar-bz2: true needs to be set for caching to work properly!
+      use-only-tar-bz2: false
+
+  - name: Cache conda
+    uses: actions/cache@v3
+    id: condacache
+    env:
+      # Increase this value to reset cache if .environment.yml has not changed
+      CACHE_NUMBER: 0
+    with:
+      path: |
+        /usr/share/miniconda/envs/lmfdb
+      key:
+        ${{ runner.os }}-conda-${{ env.CACHE_NUMBER }}-${{
+        hashFiles('.environment.yml') }}
+
+  - name: Install Julia
+    uses: julia-actions/setup-julia@v2
+    with:
+      version: '1'          # latest version
+
+  - name: Load Julia packages from cache
+    id: julia-cache
+    uses: julia-actions/cache@v2      
+
+  - name: Install Oscar
+    shell: bash -l {0}
+    run: |
+      julia -e 'using Pkg; Pkg.add("Oscar"); using Oscar'
+
+  - name: Run install script
+    shell: bash -l {0}
+    # Only need to run install when deps has been changed
+    if: steps.condacache.outputs.cache-hit != 'true'
+    run: conda env create -f .environment.yml  || conda env update -f .environment.yml
+
+  - name: Show conda info
+    shell: bash -l {0}
+    run: |
+      conda info
+      conda list
+
+  - name: Cache pip
+    uses: actions/cache@v3
+    with:
+      # This path is specific to Ubuntu
+      path: ~/.cache/pip
+      # Look to see if there is a cache hit for the corresponding requirements file
+      key: ${{ runner.os }}-pip-${{ hashFiles('requirements.txt') }}
+      restore-keys: |
+        ${{ runner.os }}-pip-
+        ${{ runner.os }}-
+
+  - name: pip stuff
+    shell: bash -l {0}
+    run: |
+      sage -pip install -r requirements.txt

.github/workflows/snippet_generate.yml

@@ -0,0 +1,30 @@
+name: Generate Snippet Code Files
+
+on:
+  push:
+    paths:
+      - '**/code*.yaml'
+
+jobs:
+  snippet-generate:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4 # Or a specific version
+
+      - name: Set up environment
+        uses: ./.github/actions/snippet_setup
+
+      - name: Generate snippets
+        if: matrix.files != 'lint'
+        shell: bash -l {0}
+        run: |
+          sage -python lmfdb/tests/generate_snippet_tests.py generate -i magma
+
+      - name: Create Pull Request
+        uses: peter-evans/create-pull-request@v7
+        with:
+          commit-message: snippet code test files generated by action
+          title: Code snippets from snippet-generate action
+          body: This is an auto-generated PR with code snippets from yaml files
+          labels: code snippets, automated pr

.github/workflows/snippet_test.yml

@@ -0,0 +1,64 @@
+name: Test Snippet Code files
+
+on:
+  schedule:
+    - cron: '0 0 1,15 * *'
+  workflow_dispatch: {}
+
+jobs:
+  snippet-test:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4 # Or a specific version
+
+      - name: Set up environment
+        uses: ./.github/actions/snippet_setup
+
+      - name: Test snippets
+        if: matrix.files != 'lint'
+        id: testing_step
+        shell: bash -l {0}
+        run: |
+          sage -python lmfdb/tests/generate_snippet_tests.py generate -i magma -e snippet_error_file.md
+
+      - name: Read error file
+        if: ${{ hashFiles('**/snippet_error_file.md') }}
+        id: read_error_file
+        run: |
+          {
+          echo 'ERROR_CONTENTS<<EOF'
+          cat snippet_error_file.md
+          echo EOF
+          } >> "$GITHUB_OUTPUT"
+
+      - name: Create or update snippet error issue
+        if: ${{ hashFiles('**/snippet_error_file.md') }}
+        uses: ovsds/create-or-update-unique-issue-action@v1
+        with:
+          title: "(Auto-generated) Errors in code snippets"
+          body: ${{ steps.read_error_file.outputs.ERROR_CONTENTS }}
+          unique-title-includes: "(Auto-generated) Errors in code snippets"
+
+      - name: Delete error log file
+        if: ${{ hashFiles('**/snippet_error_file.md') }}
+        shell: bash -l {0}
+        run: |
+          rm snippet_error_file.md
+        
+      - name: Check for diff
+        id: diff_check
+        run: |
+          # Get the diff and save it to a file.
+          git diff --relative --exit-code > changes.diff
+
+      - name: Report diff
+        if: ${{ failure() && steps.diff_check.conclusion == 'failure' }}
+        run: echo "::warning::Nontrivial diff detected. See the 'repo-diff' artifact for details."
+
+      - name: Upload diff as artifact
+        if: ${{ failure() && steps.diff_check.conclusion == 'failure' }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: repo-diff
+          path: changes.diff

CONTRIBUTORS.yaml

@@ -114,6 +114,10 @@ name: John Cremona
 affil: University of Warwick
 url: https://www2.warwick.ac.uk/fac/sci/maths/people/staff/john_cremona/
 ---
+name: Håvard Damm-Johnsen
+affil: University of Gothenburg
+url: https://havarddj.github.io/
+--- 
 name: Rachel Davis
 affil: Purdue University
 url: https://www.math.purdue.edu/~davis705

lmfdb/api/api.py

@@ -6,7 +6,7 @@
 from psycopg2.extensions import QueryCanceledError
 from lmfdb import db
 from psycodict.encoding import Json
-from lmfdb.utils import flash_error
+from lmfdb.utils import flash_error, comma
 from lmfdb.utils.datetime_utils import utc_now_naive
 from flask import (render_template, request, url_for, current_app,
                    abort, redirect, Response)
@@ -137,11 +137,11 @@ def split_db(tablename):
                 'tablespace': tablespaces.get(tablename, ""),
             }
     dataSize = size - indexSize
-    info['ntables'] = len(table_sizes)
-    info['nobjects'] = nobjects
-    info['size'] = mb(size)
-    info['dataSize'] = mb(dataSize)
-    info['indexSize'] = mb(indexSize)
+    info['ntables'] = comma(len(table_sizes))
+    info['nobjects'] = comma(nobjects)
+    info['size'] = comma(mb(size))
+    info['dataSize'] = comma(mb(dataSize))
+    info['indexSize'] = comma(mb(indexSize))
     if info['sortby'] == 'name':
         sortedkeys = sorted(stats)
     elif info['sortby'] == 'objects' and info['groupby'] == 'db':

lmfdb/app.py

@@ -719,6 +719,7 @@ def WhiteListedRoutes():
         'Character/calc-jacobi/Dirichlet',
         'Character/calc-kloosterman/Dirichlet',
         'Character/calc-value/Dirichlet',
+        'datasets',
         'EllipticCurve',
         'Field',
         'GaloisGroup',
@@ -774,6 +775,7 @@ def WhiteListedRoutes():
         'news',
         'not_yet_implemented',
         'random',
+        'rcs',
         'robots.txt',
         'search',
         'sitemap',

lmfdb/classical_modular_forms/code-form.yaml

@@ -43,23 +43,35 @@ dimensions-spaces:
     mfdim([N,k,chi],1) \\ Cusps
     mfdim([N,k,chi],0) \\ New
 
-initialize-newspace:
+initialize-newspace-common: &initialize-newspace-common
   comment: Compute space of new eigenforms
   pari: |
     [N,k,chi] = [{N},{k},Mod({conrey_index},{N})]
     mf = mfinit([N,k,chi],0)
     lf = mfeigenbasis(mf)
-  sage: |
-    from sage.modular.dirichlet import DirichletCharacter
-    H = DirichletGroup({N}, base_ring=CyclotomicField({sage_zeta_order}))
-    chi = DirichletCharacter(H, H._module({sage_genvalues}))
-    N = Newforms(chi, {k}, names="a")
   magma: |
     //Please install CHIMP (https://github.com/edgarcosta/CHIMP) if you want to run this code
     chi := DirichletCharacter("{N}.{conrey_index}");
     S:= CuspForms(chi, {k});
     N := Newforms(S);
 
+initialize-newspace-weight-1:
+  <<: *initialize-newspace-common
+  sage: |
+    from sage.modular.dirichlet import DirichletCharacter
+    H = DirichletGroup({N}, base_ring=CyclotomicField({sage_zeta_order}))
+    chi = DirichletCharacter(H, H._module({sage_genvalues}))
+    B = ModularForms(chi, 1).cuspidal_submodule().basis()
+    N = [B[i] for i in range(len(B))]
+
+initialize-newspace-weight-not-1:
+  <<: *initialize-newspace-common
+  sage: |
+    from sage.modular.dirichlet import DirichletCharacter
+    H = DirichletGroup({N}, base_ring=CyclotomicField({sage_zeta_order}))
+    chi = DirichletCharacter(H, H._module({sage_genvalues}))
+    N = Newforms(chi, {k}, names="a") 
+
 coeff-field:
   comment: Coefficient field, relative polynomial
   pari: |

lmfdb/classical_modular_forms/main.py

@@ -306,6 +306,33 @@ def parse_prec(info):
     return []
 
 
+def validate_format_parameter(format_param):
+    """
+    Validate the format parameter for newform display.
+
+    Args:
+        format_param: The format parameter to validate
+
+    Returns:
+        str: validated format parameter (defaults to 'embed' if None or invalid)
+
+    Side effects:
+        Flashes error message if format parameter is invalid
+    """
+    valid_formats = ['embed', 'analytic_embed', 'satake', 'satake_angle']
+
+    # Default to 'embed' if format is None
+    if format_param is None:
+        return 'embed'
+
+    # Check if format is valid
+    if format_param not in valid_formats:
+        flash_error("Invalid format parameter '%s'. Valid formats are: %s" % (format_param, ', '.join(valid_formats)))
+        format_param = 'embed'
+
+    return format_param
+
+
 def eta_quotient_texstring(etadata):
     r"""
     Returns a latex string representing an eta quotient.
@@ -357,7 +384,9 @@ def render_newform_webpage(label):
 
     info = to_dict(request.args)
     info['display_float'] = display_float
-    info['format'] = info.get('format', 'embed')
+
+    # Validate format parameter
+    info['format'] = validate_format_parameter(info.get('format'))
 
     if label in ETAQUOTIENTS:
         info['eta_quotient'] = eta_quotient_texstring(ETAQUOTIENTS[label])