Skip to content

Commit c781e4e

Browse files
authored
Merge pull request #6343 from assaferan/issue_5432
fixing issue 5432 when downloading a modular form to Magma
2 parents 5aae7d4 + 1ce2c5c commit c781e4e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lmfdb/classical_modular_forms/download.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -492,13 +492,13 @@ def _magma_MakeCharacters(self, newform, hecke_nf):
492492
self.explain.append(explain)
493493
out += [
494494
explain,
495-
'function MakeCharacter_%d_%s_Hecke(Kf)' % (newform.level, newform.char_orbit_label),
495+
'function MakeCharacter_%d_%s_Hecke( : Kf := None)' % (newform.level, newform.char_orbit_label),
496496
' ' + magma.assign('N', level).rstrip('\n'), # level
497497
' ' + magma.assign('order', order).rstrip('\n'), # order of the character
498498
' ' + magma.assign('char_gens', char_gens).rstrip('\n'), # generators
499499
' ' + magma.assign('char_values', char_values).rstrip('\n'), # chi(gens[i]) = zeta_n^exp[i]
500500
' assert UnitGenerators(DirichletGroup(N)) eq char_gens;',
501-
' values := ConvertToHeckeField(char_values : pass_field := true, Kf := Kf); // the value of chi on the gens as elements in the Hecke field',
501+
' values := ConvertToHeckeField(char_values : pass_field := ISA(Type(Kf), Fld), Kf := Kf); // the value of chi on the gens as elements in the Hecke field',
502502
' F := Universe(values);// the Hecke field',
503503
' chi := DirichletCharacterFromValuesOnUnitGenerators(DirichletGroup(N,F),values);',
504504
' return chi;',
@@ -557,7 +557,7 @@ def _magma_qexpCoeffs(self, newform, hecke_nf):
557557
' ' + magma.assign('weight', newform.weight).rstrip('\n'),
558558
' ' + magma.assign('raw_aps', hecke_nf['ap']).rstrip('\n'),
559559
' aps := ConvertToHeckeField(raw_aps);',
560-
' chi := MakeCharacter_%d_%s_Hecke(Universe(aps));' % (newform.level, newform.char_orbit_label),
560+
' chi := MakeCharacter_%d_%s_Hecke( : Kf := Universe(aps));' % (newform.level, newform.char_orbit_label),
561561
' return ExtendMultiplicatively(weight, aps, chi);',
562562
'end function;',
563563
]

0 commit comments

Comments
 (0)