Skip to content

Commit e753ec7

Browse files
authored
Merge pull request #6725 from roed314/external_def
Fix bug in DEFINES
2 parents 4206949 + 9012c56 commit e753ec7

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

lmfdb/knowledge/knowl.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,7 @@ def external_definition_link(site, xid):
804804
return f"https://doi.org/{xid}", xid, fragment
805805
if site == "groupprops":
806806
# example xid="Alternating_group"
807-
return f"https://groupprops.subwiki.org/wiki/{xid}", xid, fragment
807+
return f"https://groupprops.subwiki.org/wiki/{xid}", "groupprops:" + xid, fragment
808808
if site == "href":
809809
# href contains both the link and text for displaying
810810
if not xid or xid[0] != "{" or xid[-1] != "}" or xid.count("}{") != 1:
@@ -851,8 +851,11 @@ def knowl_definition(title,
851851
if len(kwargs) == 1:
852852
try:
853853
site, xid = list(kwargs.items())[0]
854-
url = external_definition_link(site, xid)
855-
return f'<a href="{url}"><strong>{title}</strong></a>'
854+
url, disp, fragment = external_definition_link(site, xid)
855+
link = f'<a href="{url}"><strong>{title}</strong></a>'
856+
if fragment:
857+
link += f" ({fragment})"
858+
return link
856859
except ValueError:
857860
pass
858861
return display_knowl("lmfdb.external_definitions", title, kwargs=kwargs, strong=True)

0 commit comments

Comments
 (0)