Skip to content

Commit eb5f57e

Browse files
Copilotedgarcosta
andcommitted
Simplify test_issue_6691_fixed per review feedback
Check specifically for '1.2.A.c26568' in response data rather than multiple possible strings. Co-authored-by: edgarcosta <322822+edgarcosta@users.noreply.github.com>
1 parent c02d179 commit eb5f57e

File tree

1 file changed

+2
-15
lines changed

1 file changed

+2
-15
lines changed

lmfdb/sato_tate_groups/test_st.py

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -120,19 +120,6 @@ def test_issue_6691_fixed(self):
120120
"""Test that issue #6691 is fixed: labels with non-numeric component group parts don't crash"""
121121
# The specific URL from issue #6691 that was causing ValueError
122122
page = self.tc.get('/SatoTateGroup/1.2.A.c13284')
123-
# Should not crash and should return some reasonable response
124-
# Either a valid page or a redirect to search results
125123
data = page.get_data(as_text=True)
126-
# Verify we get some reasonable response (not a 500 error)
127-
assert ('The database currently contains' in data or 'SU(2)' in data)
128-
129-
# Test a few more similar cases to ensure robustness
130-
test_labels = ['1.2.A.c100', '2.2.B.d50']
131-
for label in test_labels:
132-
page = self.tc.get(f'/SatoTateGroup/{label}')
133-
data = page.get_data(as_text=True)
134-
# Should not crash - either get valid page, redirect, or search page
135-
# The important thing is no ValueError exception is raised
136-
assert ('The database currently contains' in data or
137-
'SU(2)' in data or 'Sato-Tate' in data or 'Browse' in data or
138-
'Redirecting' in data)
124+
# Check that the page loads correctly and shows a supergroup
125+
assert '1.2.A.c26568' in data

0 commit comments

Comments
 (0)