Master Mixer Track Mute button is on when loading empty.mmp

[bratpeki]

System Information

Manjaro (Arch-based)

LMMS Version(s)

Nightly

Most Recent Working Version

LMMS 1.2.2 (thx Spherexx!), but not tested that extensively

Bug Summary

It happens across the board for most of my projects.

It's only visual, clicking it "unmutes" it. Loading again, even if saved, shows it as muted again.

Uploaded a baseline for testing. link.

Expected Behaviour

The buttons doesn't show that the track is muted.
i.e. The mute button on "Master" isn't on.

Steps To Reproduce

1. Load empty.mmp on the lastest nightly.
2. The master mute button is on.

Logs

No response

Screenshots / Minimum Reproducible Project

No response

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[bratpeki]

Looking into my own template, and discussing it with @Monospace-V, it looks like this is an issue on my part!

The way I made empty.mmp is:

1. Opened a new project with the "empty" template
2. Saving that project

That's literally empty.mmp.

Reading into it, I saw this:

<mixer height="389" maximized="0" minimized="0" visible="1" width="607" x="5" y="310">
  <mixerchannel muted="0" name="Master" num="0" soloed="0" volume="1">
	<fxchain enabled="0" numofeffects="0"/>
	<connection>
	  <muted>
		<Midicontroller basevelocity="127" fixedinputvelocity="-1" fixedoutputnote="-1" fixedoutputvelocity="-1" inports="" inputchannel="1" inputcontroller="36" name="MIDI ch1 ctrl36" outputchannel="1" outputcontroller="-1" outputprogram="1" readable="1" type="2" writable="0"/>
	  </muted>
	</connection>
  </mixerchannel>
</mixer>

Removing the <muted> tag and everything inside it fixes the issue!
The problem is that I have no idea how it gets into the saved project.
For reference, here's the template as-is in our project: link.

[Monospace-V]

I cannot reproduce this itself, but I find that muting master channel breaks the mute button:

1. Mute master in nightly, any project
2. Open another project IN THE SAME INSTANCE OF LMMS
3. Notice: Master APPEARS muted, but is not in fact muted. The mute button can be clicked to make it look inactive again, but now it cannot be turned back on.
4. The project can be SAVED in any of the two states mentioned in step 3, but:

• saving it after making the mute button look inactive again causes it to look constantly muted and unchangeable when opened again.
• saving it without clicking the mute button into the inactive state makes it save into the state mentioned in step 3.
  The nature of what happens upon save in both cases is not relevant,

What IS relevant is that , upon opening a new project after muting the master channel, when this issue happens, if I SAVE the project in this messed-up state, it adds an XML tag as <connection> <muted>

While it is confusing that peki's fresh build of LMMS seems to have this bug triggered with the Empty template, mine doesn't have it, but my saved files with this bug do.

[bratpeki]

Yeah, I'm almost certain the MIDI connection to mute it is made during saving. Need to dig deeper, though.

[Monospace-V]

I can still reproduce my issue with MIDI on Dummy, unlike peki's Empty mmp that loads normally with MIDI on Dummy.
Worth noting that I'm testing on Windows. It is possible peki's OS on building the template causes this?

[sakertooth]

Didn't I just fix this in #8145?

[anytizer]

Plus, you may have to save that file with newer version. Otherwise, a toast message appears,

[bratpeki]

Didn't I just fix this in #8145?

Looking at it, it looks like a different issue.
Check this out!

[musikBear]

it says:

So muted is logical == false
Does that logically go with the tag <muted>

[bratpeki]

Which further implies the connection to the MIDI device is likely what makes it muted.