Piano roll opening with minimum height after loading project

[extern-stat]

System Information

Windows 10

LMMS Version(s)

Version 1.3.0-alpha.1.956+f5688e9 (win32/x86_64, Qt 5.15.6, GCC 13-win32)

Most Recent Working Version

Commit 6854a65

Bug Summary

The piano roll window can open with minimum height after loading a project under certain conditions. This bug was introduced by #3532.

Expected Behaviour

The piano roll window should open with the height saved in the project.

Steps To Reproduce

• Open the piano roll
• Resize the piano roll
• Close the piano roll
• Load a project which was saved with the piano roll window closed (or click Create New Project)
• Open the piano roll
• The piano roll will open with minimum height

Logs

No response

Screenshots / Minimum Reproducible Project

piano_roll.mp4

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[yohannd1]

Weirdly enough I cannot replicate this on Linux/Qt5. Maybe it's a windows-specific bug?
Also, could you send me your template project? I wanna check whether this is related to / fixed by #8204.

[extern-stat]

@yohannd1 My template project in the video is just the default one from a fresh install of LMMS Nightly, although I believe this bug should happen on any template project that doesn't have the piano roll open by default. I tried replicating the bug on Linux as well, and was able to replicate it, so I believe it happens on all platforms. I also checked #8204 to see if that fixes it, but it looks like the bug still happens on that PR.

[sqrvrt]

Will check soon because it's very likely it's introduced by #3532. I remember doing something so that it stopped doing this initially, so it's possible i just need to apply it on reloads too _{if i remember what i actually did...}

[extern-stat]

Update: I tested this some more and it looks like the bug affects all windows, not just Piano Roll (although I couldn't get it to happen on Song Editor, for some reason).

[sqrvrt]

To be more specific i think it affects main windows that are initially hidden on default project

[sqrvrt]

The reason for it happening is very likely that the window frame gets resized when the content is missing, and thus get set to 0 size, which then gets bumped to minimum size