[v0.9.537] Fixed issue where sub-stats/criteria of their hidden parent still contributed to the shared flag. Removed deltaTime fully from tracker_update function. Updated "Enable Overlay" tooltip to mention that more overlay-related settings appear.

Author: LNXSeus

source/main.cpp

@@ -1776,7 +1776,7 @@ int main(int argc, char *argv[]) {
                 );
 
                 // Now update progress with the correct paths
-                tracker_update(tracker, &deltaTime, &app_settings);
+                tracker_update(tracker, &app_settings);
 
                 // Update TITLE of the tracker window with some info, similar to the debug print
                 tracker_update_title(tracker, &app_settings);

source/main.h

@@ -55,7 +55,7 @@ const char* get_notes_manifest_path();
 #define TRACKER_TITLE "Advancely"
 
 // This is the version that gets compared with the latest release tag on GitHub
-#define ADVANCELY_VERSION "v0.9.535" // vMAJOR.MINOR.PATCH // Update this always, SAME FORMAT ON RELEASE TAG!
+#define ADVANCELY_VERSION "v0.9.537" // vMAJOR.MINOR.PATCH // Update this always, SAME FORMAT ON RELEASE TAG!
 #define ADVANCELY_ICON_PATH "/gui/Advancely_Logo_NoText.png" // Starting from /gui folder
 #define ADVANCELY_LOGO_PATH "/gui/Advancely_Logo.png" // Starting from /gui folder
 #define ADVANCELY_LOGO_SIZE 512.0f // Logo size on startup message window or update successful window

source/settings.cpp

@@ -902,7 +902,8 @@ void settings_render_gui(bool *p_open, AppSettings *app_settings, ImFont *roboto
         if (selected_version <= MC_VERSION_1_6_4) {
             // Legacy
             snprintf(enable_overlay_tooltip_buffer, sizeof(enable_overlay_tooltip_buffer),
-                     "Enables a separate, customizable window to show your progress, perfect for streaming.\n\n"
+                     "Enables a separate, customizable window to show your progress, perfect for streaming.\n"
+                     "More overlay-related settings become visible.\n\n"
                      "Overlay Layout:\n"
                      " • Row 1: Sub-stats of complex stats (if not template hidden).\n"
                      "   (If two visible items share an icon, the parent's icon is overlaid.)\n"

source/temp_creator.cpp

@@ -4281,7 +4281,7 @@ void temp_creator_render_gui(bool *p_open, AppSettings *app_settings, ImFont *ro
                     if (ImGui::IsItemHovered()) {
                         char hidden_tooltip_buffer[256];
                         snprintf(hidden_tooltip_buffer, sizeof(hidden_tooltip_buffer),
-                                 "If checked, this stat will be fully hidden on the overlay\n"
+                                 "If checked, this stat (and all sub-stats) will be fully hidden on the overlay\n"
                                  "and hidden settings-based on the tracker.\n"
                                  "Visibility can be toggled in the main tracker settings");
                         ImGui::SetTooltip("%s", hidden_tooltip_buffer);

source/tracker.cpp

@@ -1451,6 +1451,9 @@ static int count_all_icon_hashes(Tracker *t, IconHashCounter **counts, int capac
     for (int i = 0; i < cat_count; i++) {
         if (categories[i]->is_single_stat_category) continue;
 
+        // If the parent category is hidden, children should not contribute to shared count (not visible)
+        if (categories[i]->is_hidden) continue;
+
         for (int j = 0; j < categories[i]->criteria_count; j++) {
             TrackableItem *crit = categories[i]->criteria[j];
 
@@ -1490,6 +1493,9 @@ static void flag_shared_icons_by_hash(IconHashCounter *counts, int unique_count,
     for (int i = 0; i < cat_count; i++) {
         if (categories[i]->is_single_stat_category) continue;
 
+        // Skip processing hidden parents here as well, children are also hidden
+        if (categories[i]->is_hidden) continue;
+
         for (int j = 0; j < categories[i]->criteria_count; j++) {
             TrackableItem *crit = categories[i]->criteria[j];
             crit->is_shared = false;
@@ -2624,8 +2630,7 @@ void tracker_events(Tracker *t, SDL_Event *event, bool *is_running, bool *settin
 }
 
 // Periodically recheck file changes
-void tracker_update(Tracker *t, float *deltaTime, const AppSettings *settings) {
-    (void) deltaTime;
+void tracker_update(Tracker *t, const AppSettings *settings) {
 
     // Detect if the world has changed since the last update.
     if (t->template_data->last_known_world_name[0] == '\0' || // Handle first-time load

source/tracker.h

@@ -212,10 +212,9 @@ void tracker_events(Tracker *t, SDL_Event *event, bool *is_running, bool *settin
  * In the future, it could be used for animations or periodic data refreshing.
  *
  * @param t A pointer to the Tracker struct.
- * @param deltaTime A pointer to the frame's delta time, for future use in animations.
  * @param settings A pointer to the loaded application settings.
  */
-void tracker_update(Tracker *t, float *deltaTime, const AppSettings *settings);
+void tracker_update(Tracker *t, const AppSettings *settings);
 
 /**
  * @brief Renders the tracker window's contents.