-
Notifications
You must be signed in to change notification settings - Fork 98
Description
Hello, after building and testing this project with branch ros2, I found something unexpected.
I noticed the package.xml file in this package contains the following content which means a format check.
<test_depend>ament_cpplint</test_depend>
But there are no corresponding test section in CMakeLists.txt resulting in no testing programs to run actually.
So I think if we want the ament_lint tools to do a format check, maybe need add the testing section in the CMakeLists.txt like following:
if(BUILD_TESTING)
find_package(ament_cmake_cpplint REQUIRED)
ament_cpplint()
endif()
After adding the content and setting the BUILD_TESTING option, amen_lint_cpplit can be executed correctly after running command colcon test.
But there are some format errors after testing. Here is the result file:
If we do not need the ament_lint_tools, I think the test_depend might be a redundant dependency that could be removed to reduce the burden of project maintenance.
I would appreciate it if you could tell me how do you think of this?
Thanks!