Skip to content

Commit 358ab50

Browse files
committed
Feedback
1 parent 67fbc89 commit 358ab50

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

libs/labelbox/src/labelbox/schema/member.py

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
from typing import Optional
2-
from labelbox.exceptions import (
3-
MalformedQueryException,
2+
from lbox.exceptions import (
43
ResourceNotFoundError,
5-
UnprocessableEntityError,
64
)
75
from typing import Set, Iterator, Any, List
86
from pydantic import (
@@ -161,11 +159,12 @@ def get(self) -> "Member":
161159
"""
162160
params = {"userId": self.id}
163161

164-
result = self.client.execute(query, params, experimental=True)
165-
if not result:
166-
raise ResourceNotFoundError(
167-
message="Failed to find user as user does not exist"
168-
)
162+
result = self.client.execute(
163+
query,
164+
params,
165+
experimental=True,
166+
raise_return_resource_not_found=True,
167+
)
169168

170169
user = {
171170
**result["user"],
@@ -241,14 +240,13 @@ def update(self) -> "Member":
241240
if self.id == self._current_user_id:
242241
raise ValueError("Unable to update self")
243242

244-
try:
245-
result = self.client.execute(query, params, experimental=True)
246-
if not result:
247-
raise ResourceNotFoundError(
248-
message="Failed to update member as member does not exist"
249-
)
250-
except MalformedQueryException as e:
251-
raise UnprocessableEntityError("Failed to update member") from e
243+
self.client.execute(
244+
query,
245+
params,
246+
experimental=True,
247+
raise_return_resource_not_found=True,
248+
)
249+
252250
return self
253251

254252
def delete(self) -> bool:
@@ -281,11 +279,13 @@ def delete(self) -> bool:
281279

282280
params = {"id": self.id}
283281

284-
result = self.client.execute(query, params, experimental=True)
285-
if not result:
286-
raise ResourceNotFoundError(
287-
message="Failed to delete member as member does not exist"
288-
)
282+
result = self.client.execute(
283+
query,
284+
params,
285+
experimental=True,
286+
raise_return_resource_not_found=True,
287+
)
288+
289289
return result["updateUser"]["deleted"]
290290

291291
def _get_project_memberships(self, user_id: str) -> Set[ProjectMembership]:

0 commit comments

Comments
 (0)