Skip to content

Commit e878898

Browse files
committed
wrap class by constructor function
1 parent f33cf09 commit e878898

25 files changed

+55
-51
lines changed

docs/client-demo.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ const NetLicensingDemo = async () => {
2121
TokenService,
2222
} = NetLicensing;
2323

24-
const context = new Context().setUsername('demo').setPassword('demo');
24+
const context = Context();
25+
context.setUsername('demo');
26+
context.setPassword('demo');
2527

2628
const randomNumber = Math.random().toString(36).slice(2);
2729
const productNumber = numberWithPrefix('P', randomNumber);
@@ -211,7 +213,7 @@ const NetLicensingDemo = async () => {
211213

212214
// region ********* Validate
213215

214-
const validationParameters = new ValidationParameters();
216+
const validationParameters = ValidationParameters();
215217
validationParameters.setProductNumber(productNumber);
216218
validationParameters.setLicenseeName(numberWithPrefix('Licensee-', Math.random().toString(36).slice(2)));
217219
validationParameters.setProductModuleValidationParameters(productModuleNumber, {

eslint.config.mjs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ export default defineConfig([
1414
{
1515
...pluginVitest.configs.recommended,
1616
files: ['**/*.spec.ts', '**/*.test.ts'],
17+
rules: {
18+
'vitest/expect-expect': ['error', { assertFunctionNames: ['expect', 'expectEntity', 'expectEntityProp'] }],
19+
}
1720
},
1821

1922
{
@@ -30,7 +33,7 @@ export default defineConfig([
3033
import: importPlugin,
3134
},
3235

33-
ignores: ['/node_modules', '/dist'],
36+
ignores: ['/node_modules', '/dist', '/docs'],
3437

3538
rules: {
3639
// General

src/converters/itemToTransaction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export default <T extends object = TransactionProps>(item?: Item) => {
3838
const transaction = Transaction({ number: transactionNumber });
3939
const license = License({ number: licenseNumber });
4040

41-
return new LicenseTransactionJoin(transaction, license);
41+
return LicenseTransactionJoin(transaction, license);
4242
});
4343
}
4444

src/entities/LicenseTransactionJoin.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import type { Transaction } from '@/types/entities/Transaction';
1010
* @copyright 2017 Labs64 NetLicensing
1111
*/
1212

13-
export default class LicenseTransactionJoin implements ILicenseTransactionJoin {
13+
class LicenseTransactionJoin implements ILicenseTransactionJoin {
1414
transaction: Transaction;
1515
license: License;
1616

@@ -35,3 +35,5 @@ export default class LicenseTransactionJoin implements ILicenseTransactionJoin {
3535
return this.license;
3636
}
3737
}
38+
39+
export default (transaction: Transaction, license: License) => new LicenseTransactionJoin(transaction, license);

src/errors/NlicError.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { AxiosError, AxiosResponse, InternalAxiosRequestConfig } from 'axios';
22

33
export default class NlicError<T = unknown, D = unknown> extends AxiosError<T, D> {
44
isNlicError = true;
5-
isAxiosError = true;
65

76
constructor(
87
message?: string,
@@ -14,8 +13,6 @@ export default class NlicError<T = unknown, D = unknown> extends AxiosError<T, D
1413
) {
1514
super(message, code, config, request, response);
1615
this.name = 'NlicError';
17-
this.isNlicError = true;
18-
this.isAxiosError = true;
1916

2017
if (stack) {
2118
this.stack = stack;

src/services/LicenseeService.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import { RequestConfig } from '@/types/services/Service';
2727
import { Context } from '@/types/vo/Context';
2828
import { Page as IPage } from '@/types/vo/Page';
2929
import { ValidationParameters } from '@/types/vo/ValidationParameters';
30+
import { ValidationResults as IValidationResults } from '@/types/vo/ValidationResults';
3031

3132
// utils
3233
import { encode } from '@/utils/filter';
@@ -236,7 +237,7 @@ const licenseeService: LicenseeService = {
236237
number: string,
237238
validationParameters?: ValidationParameters,
238239
config?: RequestConfig,
239-
): Promise<ValidationResults> {
240+
): Promise<IValidationResults> {
240241
ensureNotEmpty(number, 'number');
241242

242243
const data: Record<string, string | boolean> = {};
@@ -279,7 +280,7 @@ const licenseeService: LicenseeService = {
279280

280281
const response = await Service.post(context, `${endpoint}/${number}/${endpointValidate}`, data, config);
281282

282-
const validationResults = new ValidationResults();
283+
const validationResults = ValidationResults();
283284

284285
const ttl = response.data.ttl;
285286

src/types/services/LicenseeService.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ import { RequestConfig } from '@/types/services/Service';
1313
import { Context } from '@/types/vo/Context';
1414
import { Page } from '@/types/vo/Page';
1515
import { ValidationParameters } from '@/types/vo/ValidationParameters';
16-
17-
// vo
18-
import ValidationResults from '@/vo/ValidationResults';
16+
import { ValidationResults } from '@/types/vo/ValidationResults';
1917

2018
export interface LicenseeService {
2119
get<T extends object = LicenseeProps>(context: Context, number: string, config?: RequestConfig): Promise<Licensee<T>>;

src/types/vo/ValidationResults.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export interface ProductModuleValidation {
1010
[key: string]: string;
1111
}
1212

13-
export interface ValidationResult {
13+
export interface ValidationResults {
1414
readonly validations: Record<string, ProductModuleValidation>;
1515
ttl?: Date;
1616

src/vo/Context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,4 +82,4 @@ class Context implements IContext {
8282
}
8383
}
8484

85-
export default Context;
85+
export default (props?: ContextConfig) => new Context(props);

src/vo/ValidationParameters.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,4 +104,4 @@ class ValidationParameters implements IValidationParameters {
104104
}
105105
}
106106

107-
export default ValidationParameters;
107+
export default () => new ValidationParameters();

0 commit comments

Comments
 (0)