update to Java 17 again

Author: jumpingpxl

.github/workflows/build.yml

@@ -18,7 +18,7 @@ jobs:
         uses: actions/setup-java@v3
         with:
           distribution: 'temurin'
-          java-version: '8'
+          java-version: '17'
       - name: Grant execute permission for gradlew
         run: chmod +x gradlew
       - name: Build Release Artifacts with Gradle

README.md

@@ -36,7 +36,7 @@ the [LabyMod Developer Portal](https://wiki.labymod.net).
 
 ### Prerequisites
 
-- Java Development Kit (JDK) 8 or higher
+- Java Development Kit (JDK) 17 or higher
 
 ### Steps
 

api/src/main/java/net/labymod/serverapi/api/payload/io/PayloadWriter.java

@@ -187,8 +187,7 @@ public void writeOptionalString(@Nullable String value) {
   public void writeComponent(@NotNull ServerAPIComponent component) {
     byte id = 0;
     Consumer<PayloadWriter> dataWriter = null;
-    if (component instanceof ServerAPITextComponent) {
-      ServerAPITextComponent textComponent = (ServerAPITextComponent) component;
+    if (component instanceof ServerAPITextComponent textComponent) {
       if (!textComponent.getText().isEmpty()) {
         id = 1;
         dataWriter = writer -> writer.writeString(textComponent.getText());

build.gradle.kts

@@ -62,8 +62,8 @@ subprojects {
     }
 
     java {
-        sourceCompatibility = JavaVersion.VERSION_1_8
-        targetCompatibility = JavaVersion.VERSION_1_8
+        sourceCompatibility = JavaVersion.VERSION_17
+        targetCompatibility = JavaVersion.VERSION_17
     }
 
     fun adjustArchiveFileName(property: Property<String>) {

core/src/main/java/net/labymod/serverapi/core/model/display/EconomyDisplay.java

@@ -78,11 +78,10 @@ public boolean equals(Object o) {
       return true;
     }
 
-    if (!(o instanceof EconomyDisplay)) {
+    if (!(o instanceof EconomyDisplay that)) {
       return false;
     }
 
-    EconomyDisplay that = (EconomyDisplay) o;
     return this.visible == that.visible && Double.compare(this.balance, that.balance) == 0
         && Objects.equals(this.key, that.key) && Objects.equals(this.iconUrl, that.iconUrl)
         && Objects.equals(this.decimalFormat, that.decimalFormat);
@@ -121,11 +120,10 @@ public boolean equals(Object o) {
         return true;
       }
 
-      if (!(o instanceof DecimalFormat)) {
+      if (!(o instanceof DecimalFormat that)) {
         return false;
       }
 
-      DecimalFormat that = (DecimalFormat) o;
       return Double.compare(this.divisor, that.divisor) == 0 && Objects.equals(this.format,
           that.format);
     }

core/src/main/java/net/labymod/serverapi/core/model/feature/Emote.java

@@ -58,11 +58,10 @@ public boolean equals(Object o) {
       return true;
     }
 
-    if (!(o instanceof Emote)) {
+    if (!(o instanceof Emote emote)) {
       return false;
     }
 
-    Emote emote = (Emote) o;
     return this.emoteId == emote.emoteId && Objects.equals(this.uniqueId, emote.uniqueId);
   }
 

core/src/main/java/net/labymod/serverapi/core/model/feature/InteractionMenuEntry.java

@@ -101,11 +101,10 @@ public boolean equals(Object o) {
       return true;
     }
 
-    if (!(o instanceof InteractionMenuEntry)) {
+    if (!(o instanceof InteractionMenuEntry that)) {
       return false;
     }
 
-    InteractionMenuEntry that = (InteractionMenuEntry) o;
     return Objects.equals(this.displayName, that.displayName) && this.type == that.type
         && Objects.equals(this.value, that.value) && Objects.equals(this.iconUrl,
         that.iconUrl);

core/src/main/java/net/labymod/serverapi/core/model/moderation/Permission.java

@@ -83,11 +83,10 @@ public boolean equals(Object o) {
       return true;
     }
 
-    if (!(o instanceof Permission)) {
+    if (!(o instanceof Permission that)) {
       return false;
     }
 
-    Permission that = (Permission) o;
     return this.identifier.equals(that.identifier);
   }
 

core/src/main/java/net/labymod/serverapi/core/model/moderation/RecommendedAddon.java

@@ -70,11 +70,10 @@ public boolean equals(Object o) {
       return true;
     }
 
-    if (!(o instanceof RecommendedAddon)) {
+    if (!(o instanceof RecommendedAddon that)) {
       return false;
     }
 
-    RecommendedAddon that = (RecommendedAddon) o;
     return this.required == that.required && Objects.equals(this.namespace, that.namespace);
   }
 

core/src/main/java/net/labymod/serverapi/core/model/supplement/InputPrompt.java

@@ -126,11 +126,10 @@ public boolean equals(Object o) {
       return true;
     }
 
-    if (!(o instanceof InputPrompt)) {
+    if (!(o instanceof InputPrompt that)) {
       return false;
     }
 
-    InputPrompt that = (InputPrompt) o;
     return this.maxLength == that.maxLength
         && Objects.equals(this.title, that.title)
         && Objects.equals(this.placeholder, that.placeholder)