Context menu for links

This patch implements a context menu for links. In the future, we could
even check for the modifiers and open links in new windows, or private
windows - but not today.

Author: diegoiast

BrowserWindow.cpp

@@ -195,9 +195,16 @@ void BrowserWindow::debug_request(String const& request, String const& argument)
 }
 
 void BrowserWindow::new_tab()
+{
+    new_tab_with_url(QUrl());
+}
+
+void BrowserWindow::new_tab_with_url(const QUrl &url)
 {
     auto tab = make<Tab>(this);
     auto tab_ptr = tab.ptr();
+    if (!url.isEmpty())
+        tab->navigate(url.toString());
     m_tabs.append(std::move(tab));
 
     if (m_current_tab == nullptr) {

BrowserWindow.h

@@ -32,6 +32,7 @@ public slots:
     void tab_title_changed(int index, QString const&);
     void tab_favicon_changed(int index, QIcon icon);
     void new_tab();
+    void new_tab_with_url(QUrl const&);
     void close_tab(int index);
     void close_current_tab();
 

Tab.cpp

@@ -9,11 +9,13 @@
 #include "BrowserWindow.h"
 #include "History.h"
 #include "Settings.h"
-#include <QCoreApplication>
+#include <QClipboard>
 #include <QFont>
 #include <QFontMetrics>
+#include <QGuiApplication>
 #include <QPoint>
 #include <QResizeEvent>
+#include <QUrl>
 
 extern String s_serenity_resource_root;
 extern Browser::Settings* s_settings;
@@ -71,6 +73,27 @@ Tab::Tab(QMainWindow* window)
         m_location_edit->setText(url.to_string().characters());
         m_history.push(url, m_title.toUtf8().data());
     });
+
+    QObject::connect(m_view, &WebView::linkContentMenu, [this] (QPoint &localPosition, const QUrl& url, unsigned ){
+        auto global_position = this->mapToGlobal(localPosition);
+        auto menu = QMenu();
+
+        auto copyLinkAction = new QAction(tr("Copy Link"));
+        auto openLinkInTabAction = new QAction(tr("Open link in a new tab"));
+
+        menu.addAction(copyLinkAction);
+        menu.addAction(openLinkInTabAction);
+        auto res = menu.exec(global_position);
+
+        if (res == copyLinkAction) {
+            QClipboard *clipboard = QGuiApplication::clipboard();
+            clipboard->setText(url.toString());
+            qDebug() << "Copied to clipboard text:" << url.toString();
+        } else if (res == openLinkInTabAction){
+            auto browser_window = static_cast<BrowserWindow*>(m_window);
+            return browser_window->new_tab_with_url(url);
+        }
+    });
     QObject::connect(m_location_edit, &QLineEdit::returnPressed, this, &Tab::location_edit_return_pressed);
     QObject::connect(m_view, &WebView::title_changed, this, &Tab::page_title_changed);
     QObject::connect(m_view, &WebView::favicon_changed, this, &Tab::page_favicon_changed);

WebView.cpp

@@ -57,12 +57,14 @@
 #include <QCursor>
 #include <QIcon>
 #include <QLineEdit>
+#include <QMenu>
 #include <QMessageBox>
 #include <QMouseEvent>
 #include <QPaintEvent>
 #include <QPainter>
 #include <QScrollBar>
 #include <QTextEdit>
+#include <QToolTip>
 #include <QVBoxLayout>
 
 AK::String akstring_from_qstring(QString const& qstring)
@@ -75,6 +77,11 @@ QString qstring_from_akstring(AK::String const& akstring)
     return QString::fromUtf8(akstring.characters(), akstring.length());
 }
 
+QUrl qurl_from_akurl(AK::URL const& akurl)
+{
+    return QUrl(qstring_from_akstring(akurl.to_string()));
+}
+
 String s_serenity_resource_root = [] {
     auto const* source_dir = getenv("SERENITY_SOURCE_DIR");
     if (source_dir) {
@@ -219,8 +226,20 @@ class HeadlessBrowserPageClient final : public Web::PageClient {
     {
     }
 
-    virtual void page_did_request_link_context_menu(Gfx::IntPoint const&, AK::URL const&, String const&, unsigned) override
+    QPoint IntPoint_to_QPoint(Gfx::IntPoint const& position){
+        auto p = QPoint();
+        p.setX(position.x());
+        p.setY(position.y());
+        return p;
+    }
+
+    virtual void page_did_request_link_context_menu(Gfx::IntPoint const& position, AK::URL const &url, AK::String const&, unsigned modifiers) override
     {
+        auto view_offset = QPoint(m_view.horizontalScrollBar()->value(), m_view.verticalScrollBar()->value());
+        auto position_in_page = IntPoint_to_QPoint(position);
+        auto position_in_view = position_in_page - view_offset;
+        auto qurl = qurl_from_akurl(url);
+        emit m_view.linkContentMenu(position_in_view, qurl, modifiers);
     }
 
     virtual void page_did_request_image_context_menu(Gfx::IntPoint const&, AK::URL const&, String const&, unsigned, Gfx::Bitmap const*) override

WebView.h

@@ -49,6 +49,7 @@ class WebView final : public QAbstractScrollArea {
 signals:
     void linkHovered(QString, int timeout = 0);
     void linkUnhovered();
+    void linkContentMenu(QPoint &localPosition, const QUrl&, unsigned modifiers);
     void loadStarted(const URL&);
     void title_changed(QString);
     void favicon_changed(QIcon);