Skip to content
This repository was archived by the owner on Dec 25, 2022. It is now read-only.

Commit f0f2dce

Browse files
trflynn89gunnarbeutner
authored andcommitted
Stub out new WebView::ViewImplementation APIs
These were added for WebDriver, which doesn't have a Ladybird implementation yet.
1 parent 3cc6030 commit f0f2dce

File tree

2 files changed

+30
-2
lines changed

2 files changed

+30
-2
lines changed

WebContentView.cpp

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,8 +311,7 @@ void WebContentView::mouseReleaseEvent(QMouseEvent* event)
311311

312312
if (event->button() & Qt::MouseButton::BackButton) {
313313
emit back_mouse_button();
314-
}
315-
else if (event->button() & Qt::MouseButton::ForwardButton) {
314+
} else if (event->button() & Qt::MouseButton::ForwardButton) {
316315
emit forward_mouse_button();
317316
}
318317

@@ -910,6 +909,30 @@ void WebContentView::notify_server_did_update_resource_count(i32 count_waiting)
910909
(void)count_waiting;
911910
}
912911

912+
void WebContentView::notify_server_did_request_restore_window()
913+
{
914+
}
915+
916+
Gfx::IntPoint WebContentView::notify_server_did_request_reposition_window(Gfx::IntPoint const&)
917+
{
918+
return {};
919+
}
920+
921+
Gfx::IntSize WebContentView::notify_server_did_request_resize_window(Gfx::IntSize const&)
922+
{
923+
return {};
924+
}
925+
926+
Gfx::IntRect WebContentView::notify_server_did_request_maximize_window()
927+
{
928+
return {};
929+
}
930+
931+
Gfx::IntRect WebContentView::notify_server_did_request_minimize_window()
932+
{
933+
return {};
934+
}
935+
913936
void WebContentView::notify_server_did_request_file(Badge<WebContentClient>, String const& path, i32 request_id)
914937
{
915938
auto file = Core::File::open(path, Core::OpenMode::ReadOnly);

WebContentView.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,11 @@ class WebContentView final
138138
virtual String notify_server_did_request_cookie(Badge<WebContentClient>, const AK::URL& url, Web::Cookie::Source source) override;
139139
virtual void notify_server_did_set_cookie(Badge<WebContentClient>, const AK::URL& url, Web::Cookie::ParsedCookie const& cookie, Web::Cookie::Source source) override;
140140
virtual void notify_server_did_update_resource_count(i32 count_waiting) override;
141+
virtual void notify_server_did_request_restore_window() override;
142+
virtual Gfx::IntPoint notify_server_did_request_reposition_window(Gfx::IntPoint const&) override;
143+
virtual Gfx::IntSize notify_server_did_request_resize_window(Gfx::IntSize const&) override;
144+
virtual Gfx::IntRect notify_server_did_request_maximize_window() override;
145+
virtual Gfx::IntRect notify_server_did_request_minimize_window() override;
141146
virtual void notify_server_did_request_file(Badge<WebContentClient>, String const& path, i32) override;
142147

143148
signals:

0 commit comments

Comments
 (0)