Skip to content

Commit 80d4dba

Browse files
committed
Adding assertions to tests to eliminate issues where tests need to be checked manually;
1 parent 8957fc2 commit 80d4dba

File tree

4 files changed

+57
-13
lines changed

4 files changed

+57
-13
lines changed

src/test/java/net/lamgc/utils/base/ArgumentsPropertiesTest.java

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,45 @@
11
package net.lamgc.utils.base;
22

33
import net.lamgc.utils.base.ArgumentsProperties;
4+
import org.junit.Assert;
45
import org.junit.Test;
6+
import org.slf4j.Logger;
7+
import org.slf4j.LoggerFactory;
58

69
import java.util.Arrays;
10+
import java.util.HashMap;
711

812
public class ArgumentsPropertiesTest{
913

1014
private final String[] argsList = {"/a", "233", "/b : 12", "-c", "34", "-d:56", "--EF", "78", "--GH:90", "/IJ", "--KL", "-MN"};
1115

16+
private final static HashMap<String, String> valueList = new HashMap<>();
17+
18+
static {
19+
valueList.put("a", "233");
20+
valueList.put("b", "12");
21+
valueList.put("c", "34");
22+
valueList.put("d", "56");
23+
valueList.put("EF", "78");
24+
valueList.put("GH", "90");
25+
valueList.put("IJ", "");
26+
valueList.put("KL", "");
27+
valueList.put("MN", "");
28+
}
29+
30+
1231
@Test
1332
public void loadTest(){
33+
Logger log = LoggerFactory.getLogger(ArgumentsPropertiesTest.class.getSimpleName());
1434
//解析参数
1535
ArgumentsProperties argsProperties = new ArgumentsProperties(argsList);
1636
System.out.println(Arrays.toString(argsProperties.getKeysWithFlag().toArray(new String[0])));
37+
int count = 0;
1738
for(String key : argsProperties.keySet().toArray(new String[0])){
18-
System.out.println(key + ": " + argsProperties.get(key));
39+
String value = argsProperties.get(key);
40+
log.info("{}: {}", key, value);
41+
Assert.assertEquals(value, valueList.get(key));
42+
1943
}
2044
}
2145

src/test/java/net/lamgc/utils/event/EventExecutorTest.java

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,19 @@
22

33
import org.junit.Assert;
44
import org.junit.Test;
5+
import org.slf4j.Logger;
6+
import org.slf4j.LoggerFactory;
57

68
import java.util.concurrent.ArrayBlockingQueue;
79
import java.util.concurrent.ThreadPoolExecutor;
810
import java.util.concurrent.TimeUnit;
911
import java.util.concurrent.atomic.AtomicBoolean;
12+
import java.util.concurrent.atomic.AtomicInteger;
1013

1114
public class EventExecutorTest {
1215

16+
private final Logger log = LoggerFactory.getLogger(EventExecutorTest.class.getSimpleName());
17+
1318
@Test
1419
public void executorTest() throws IllegalAccessException, InterruptedException {
1520
ThreadPoolExecutor threadPoolExecutor = new ThreadPoolExecutor(
@@ -25,19 +30,26 @@ public void executorTest() throws IllegalAccessException, InterruptedException {
2530
throw new RuntimeException(e);
2631
}
2732
});
33+
AtomicInteger invokeCount = new AtomicInteger();
2834
EventExecutor executor = new EventExecutor(threadPoolExecutor);
2935
SimpleEventHandler handler = new SimpleEventHandler("handler1");
3036
SimpleEventHandler handler2 = new SimpleEventHandler("handler2");
3137
executor.addHandler(handler);
3238
executor.addHandler(handler2);
33-
executor.executor(new SimpleEventObject(1, "HelloWorld"));
39+
executor.executor(new SimpleEventObject(1, "HelloWorld", invokeCount));
3440
Thread.sleep(500L);
35-
System.out.println("OnlyHandlerTest-----");
36-
System.out.println("Execute Count: " + executor.executor(handler2, new SimpleEventObject(1, "HelloWorld")));
41+
Assert.assertEquals(invokeCount.get(), 2);
42+
invokeCount.set(0);
43+
log.info("SingleHandlerTest-----");
44+
log.info("Execute Count: {}", executor.executor(handler2, new SimpleEventObject(1, "HelloWorld", invokeCount)));
3745
Thread.sleep(500L);
46+
Assert.assertEquals(invokeCount.get(), 1);
47+
invokeCount.set(0);
3848
executor.removeHandler(handler);
39-
System.out.println("deleted Handler");
40-
executor.executor(new SimpleEventObject(2, "HelloWorld123"));
49+
log.info("deleted Handler");
50+
executor.executor(new SimpleEventObject(2, "HelloWorld123", invokeCount));
51+
Thread.sleep(500L);
52+
Assert.assertEquals(invokeCount.get(), 1);
4153
}
4254

4355
@Test
@@ -59,12 +71,14 @@ public void caughtExceptionTest() throws IllegalAccessException, InterruptedExce
5971

6072
AtomicBoolean handlerException = new AtomicBoolean(false);
6173
executor.setEventUncaughtExceptionHandler((t, handler, handlerMethod, event, cause) -> {
62-
System.out.println(
63-
"Thread: [" + t.getId() + "] " + t.getName() +
64-
", Handler: " + handler.toString() +
65-
", MethodName: " + handlerMethod.getName() +
66-
", Event: " + event.getClass().getSimpleName() +
67-
" throw Exception: " + cause.getMessage());
74+
log.info("Thread: [{}] {}, Handler: {}, MethodName: {}, Event: {} - throw Exception: {}",
75+
t.getId(),
76+
t.getName(),
77+
handler.toString(),
78+
handlerMethod.getName(),
79+
event.getClass().getSimpleName(),
80+
cause.getMessage()
81+
);
6882
cause.printStackTrace();
6983
handlerException.set(true);
7084
});

src/test/java/net/lamgc/utils/event/SimpleEventHandler.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ public SimpleEventHandler(String flag){
1010

1111
public void simpleEventHandler(SimpleEventObject event){
1212
System.out.println(this.toString() + "." + flag + " - [" + event.errorCode + "] " + event.msg);
13+
event.invokeCount.incrementAndGet();
1314
}
1415

1516
public void throwExceptionEvent(ExceptionThrowEvent event){
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
package net.lamgc.utils.event;
22

3+
import java.util.concurrent.atomic.AtomicInteger;
4+
35
public class SimpleEventObject implements EventObject {
46

57
public int errorCode;
68

79
public String msg;
810

9-
public SimpleEventObject(int errorCode, String msg){
11+
public AtomicInteger invokeCount;
12+
13+
public SimpleEventObject(int errorCode, String msg, AtomicInteger invokeCount){
1014
this.errorCode = errorCode;
1115
this.msg = msg;
16+
this.invokeCount = invokeCount;
1217
}
1318
}

0 commit comments

Comments
 (0)