@@ -2,6 +2,7 @@ const constants = require("./constants.js");
2
2
const fs = require ( "fs" ) ;
3
3
const path = require ( "path" ) ;
4
4
const process = require ( "process" ) ;
5
+ const { type } = require ( "os" ) ;
5
6
6
7
function write_file ( file_path , content ) {
7
8
fs . writeFileSync ( file_path , content , function ( err ) {
@@ -327,39 +328,39 @@ function sync_args_from_cmd(args) {
327
328
let sys_env_vars = undefined ;
328
329
if ( "sys-envs" in args ) {
329
330
sys_env_vars = args [ "sys-envs" ] ;
330
- sys_env_vars = sys_env_vars . trim ( ) ;
331
- sys_env_vars = sys_env_vars . split ( "," ) ;
332
331
} else if ( lt_config [ "run_settings" ] [ "sys_envs" ] ) {
333
-
334
332
sys_env_vars = lt_config [ "run_settings" ] [ "sys_envs" ] ;
335
- sys_env_vars = sys_env_vars . trim ( ) ;
336
- sys_env_vars = sys_env_vars . split ( ";" ) ;
337
333
}
338
334
339
335
340
336
341
337
if ( sys_env_vars ) {
338
+ sys_env_vars = sys_env_vars . trim ( ) ;
339
+ sys_env_vars = sys_env_vars . split ( ";" ) ;
342
340
let envs = { } ;
343
- console . log ( sys_env_vars ) ;
341
+
344
342
let envItem ;
345
343
let envKey ;
346
344
345
+ // perform validation
347
346
for ( index in sys_env_vars ) {
348
347
envItem = sys_env_vars [ index ] ;
349
348
if ( envItem ) {
350
- // TODO: trim spaces from the key and value
351
349
envKey = envItem . split ( "=" ) [ 0 ] ;
350
+ envKey = envKey . trim ( ) ;
352
351
if ( envKey && ! constants . WHITELISTED_ENV_VARS . includes ( envKey ) ) {
353
- reject ( `usage of unwanted environment variable detected. Allowed variables are - ${ constants . WHITELISTED_ENV_VARS } ` ) ;
352
+ reject ( `Usage of unwanted environment variable detected. Allowed variables are - ${ constants . WHITELISTED_ENV_VARS } ` ) ;
353
+ }
354
+ envValue = envItem . split ( "=" ) [ 1 ] ;
355
+ if ( envValue == undefined || envValue === "" ) {
356
+ reject ( "Value of environment variable cannot be left blank" ) ;
354
357
}
355
- envs [ envKey ] = envItem . split ( "=" ) [ 1 ] ;
358
+ envs [ envKey ] = envValue ;
356
359
}
357
-
358
360
}
359
361
lt_config [ "run_settings" ] [ "sys_envs" ] = envs ;
360
362
}
361
363
362
- console . log ( "lt_config - " , lt_config ) ;
363
364
//get specs from current directory if specs are not passed in config or cli
364
365
if (
365
366
( lt_config [ "run_settings" ] [ "specs" ] == undefined ||
0 commit comments