Skip to content

Commit ce94ab9

Browse files
comments +some changes
1 parent 4829c62 commit ce94ab9

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

commands/run.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,14 +105,14 @@ module.exports = function (args) {
105105
try {
106106
let featureFlags = await batch_runner.getFeatureFlags(
107107
lt_config["lambdatest_auth"]["username"],
108-
lt_config["lambdatest_auth"]["username"],
108+
lt_config["lambdatest_auth"]["access_key"],
109109
env
110110
);
111111
if (
112112
featureFlags.data &&
113113
featureFlags.data.includes("cypress-runon-hyper")
114114
) {
115-
if (!lt_config["tunnel_settings"]["tunnel_name"]) {
115+
if (lt_config["tunnel_settings"] && !lt_config["tunnel_settings"]["tunnel_name"]) {
116116
lt_config["tunnel_settings"]["tunnel_name"] =
117117
v4();
118118
tunnelArguments.tunnelName =

converter/converter.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,12 @@ function convertConfig(lt_config, outputFilePath) {
8383

8484
for (let key in obj.run_settings.npm_dependencies) {
8585
he_yaml.pre.push(
86-
"npm install " + key + "@" + obj.run_settings.npm_dependencies[key]
86+
"npm install " + key + "@" + obj.run_settings.npm_dependencies[key] +" --legacy-peer-deps"
8787
);
8888
}
8989

90-
if (obj.run_settings.npm_dependencies) {
91-
he_yaml.pre.push("npm install");
90+
if (!obj.run_settings.npm_dependencies) {
91+
he_yaml.pre.push("npm install --legacy-peer-deps");
9292
}
9393

9494
if (obj.tunnel_settings && obj.tunnel_settings.tunnel_name){
@@ -132,6 +132,8 @@ function convertConfig(lt_config, outputFilePath) {
132132

133133
if (obj.run_settings.useNodeVersion) {
134134
he_yaml.runtime = { language: "node", version: obj.run_settings.useNodeVersion };
135+
}else{
136+
he_yaml.runtime = { language: "node", "version": "16.18.1" };
135137
}
136138

137139
if (obj.run_settings.max_duration) {
@@ -163,11 +165,11 @@ function convertConfig(lt_config, outputFilePath) {
163165
}
164166

165167
if (obj.run_settings.cypress_version) {
166-
he_yaml.pre.push("npm install cypress@" + obj.run_settings.cypress_version);
168+
he_yaml.pre.push("npm install cypress@" + obj.run_settings.cypress_version+" --legacy-peer-deps");
167169
}
168170

169171
if (obj.run_settings.npm_dependencies.length == 0 && !obj.run_settings.cypress_version) {
170-
he_yaml.pre.push("npm install");
172+
he_yaml.pre.push("npm install --legacy-peer-deps");
171173
}
172174

173175
batcher.get_spec_files(obj.run_settings.specs, obj.run_settings.exclude_specs).then(function (specs) {

0 commit comments

Comments
 (0)