Fixes

* Upgrade playwright to fix webkit timeout issue

* Add playwright browser binaries as dependencies

* Add resolutions for backward compatibility in config

* Output error message when auth fails

Author: pinanks

package.json

@@ -21,6 +21,10 @@
   "author": "LambdaTest <[email protected]>",
   "license": "MIT",
   "dependencies": {
+    "@playwright/browser-chromium": "^1.40.1",
+    "@playwright/browser-firefox": "^1.40.1",
+    "@playwright/browser-webkit": "^1.40.1",
+    "@playwright/test": "^1.40.1",
     "@types/cross-spawn": "^6.0.4",
     "@types/node": "^20.8.9",
     "@types/which": "^3.0.2",
@@ -31,7 +35,6 @@
     "fastify": "^4.24.3",
     "form-data": "^4.0.0",
     "listr2": "^7.0.1",
-    "playwright": "^1.39.0",
     "tsup": "^7.2.0",
     "which": "^4.0.0",
     "winston": "^3.10.0"

pnpm-lock.yaml

@@ -15,7 +15,7 @@ export default (options: Record<string, string>): Context => {
         if (options.config) {
             webConfig = JSON.parse(fs.readFileSync(options.config, 'utf-8'));
         }
-        for (let viewport of webConfig.web.viewports) {
+        for (let viewport of webConfig.web.resolutions || webConfig.web.viewports) {
             viewports.push({ width: viewport[0], height: viewport[1]})
         }
     } catch (error: any) {

src/lib/ctx.ts

@@ -1,4 +1,4 @@
-import { chromium, firefox, webkit, Browser } from "playwright"
+import { chromium, firefox, webkit, Browser } from "@playwright/test"
 import { Context, WebStaticConfigSchema } from "../types.js"
 import { delDir } from "./utils.js"
 
@@ -7,6 +7,7 @@ const BROWSER_SAFARI = 'safari';
 const BROWSER_FIREFOX = 'firefox';
 const BROWSER_EDGE = 'edge';
 const EDGE_CHANNEL = 'msedge';
+const PW_WEBKIT = 'webkit';
 
 export async function captureScreenshots(ctx: Context, screenshots: WebStaticConfigSchema): Promise<number> {
     // Clean up directory to store screenshots
@@ -54,6 +55,7 @@ export async function captureScreenshots(ctx: Context, screenshots: WebStaticCon
                 await page.screenshot({ path: ssPath, fullPage: true });
 
                 let completed = (i == (totalBrowsers-1) && j == (totalScreenshots-1) && k == (totalViewports-1)) ? true : false;
+                browserName = browserName === BROWSER_SAFARI ? PW_WEBKIT : browserName;
                 ctx.client.uploadScreenshot(ctx.build, ssPath, screenshot.name, browserName, `${width}x${height}`, completed);
             }
 

src/lib/screenshot.ts

@@ -15,6 +15,7 @@ export default (ctx: Context): ListrTask<Context, ListrRendererFactory, ListrRen
                 task.title = 'Authenticated with SmartUI';
             } catch (error: any) {
                 ctx.log.debug(error.message);
+                task.output = chalk.gray(error.message);
                 throw new Error('Authentication failed');
             }
         },

src/tasks/auth.ts

@@ -54,7 +54,8 @@ export interface Build {
 export interface WebConfigSchema {
     web: {
         browsers: Array<string>;
-        viewports: Array<Array<number>>;
+        viewports?: Array<Array<number>>;
+        resolutions?: Array<Array<number>>; // for backward compatibility
     }
 }