handling threshold constraints

Author: Nick-1234531

src/lib/schemaValidation.ts

@@ -536,11 +536,15 @@ const SnapshotSchema: JSONSchemaType<Snapshot> = {
                 },
                 approvalThreshold: {
                     type: "number",
-                    errorMessage: "Invalid snapshot options; approvalThreshold must be a number"
+                    minimum: 0,
+                    maximum: 100,
+                    errorMessage: "Invalid snapshot options; approvalThreshold must be a number between 0 and 100"
                 },
                 rejectionThreshold: {
                     type: "number",
-                    errorMessage: "Invalid snapshot options; rejectionThreshold must be a number"
+                    minimum: 0,
+                    maximum: 100,
+                    errorMessage: "Invalid snapshot options; rejectionThreshold must be a number between 0 and 100"
                 }
             },
             additionalProperties: false

src/lib/server.ts

@@ -39,9 +39,9 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes
 			let { snapshot, testType } = request.body;
 			if (!validateSnapshot(snapshot)) throw new Error(validateSnapshot.errors[0].message);
 
-			if(snapshot?.options?.approvalThreshold && snapshot?.options?.rejectionThreshold) {
+			if(snapshot?.options?.approvalThreshold !== undefined && snapshot?.options?.rejectionThreshold !== undefined) {
 				if(snapshot?.options?.rejectionThreshold <= snapshot?.options?.approvalThreshold) {
-					throw new Error('Invalid snapshot; rejectionThreshold must be greater than approvalThreshold');
+					throw new Error(`Invalid snapshot options; rejectionThreshold (${snapshot.options.rejectionThreshold}) must be greater than approvalThreshold (${snapshot.options.approvalThreshold})`);
 				}
 			}