address comment reviews

Author: parthlambdatest

src/lib/httpClient.ts

@@ -102,7 +102,11 @@ export default class httpClient {
                         headers: resp.headers,
                         body: resp.data
                     })}`)
-                    return resp.data;
+                    if (resp.data !== ""){
+                        return resp.data;
+                    } else {
+                        return resp;
+                    }
                 } else {
                     log.debug(`empty response: ${JSON.stringify(resp)}`)
                     return {};

src/lib/snapshotQueue.ts

@@ -357,8 +357,24 @@ export default class Queue {
                             const presignedResponse = await this.ctx.client.getS3PresignedURLForSnapshotUpload(this.ctx, processedSnapshot.name, snapshotUuid);
                             const uploadUrl = presignedResponse.data.url;
 
-                            await this.ctx.client.uploadSnapshotToS3(this.ctx, uploadUrl, processedSnapshot)
-                            await this.ctx.client.processSnapshot(this.ctx, processedSnapshot, snapshotUuid, discoveryErrors);
+                            let snapshotUploadResponse = await this.ctx.client.uploadSnapshotToS3(this.ctx, uploadUrl, processedSnapshot);
+                            if (!snapshotUploadResponse || Object.keys(snapshotUploadResponse).length === 0) {
+                                this.ctx.log.debug(`snapshot failed; Unable to upload dom to S3`);
+                                this.processedSnapshots.push({ name: snapshot?.name, error: `snapshot failed; Unable to upload dom to S3` });
+                                if (this.ctx.browser) {
+                                    for (let context of this.ctx.browser.contexts()) {
+                                        for (let page of context.pages()) {
+                                            await page.close();
+                                            this.ctx.log.debug(`Closed browser page for snapshot ${snapshot.name}`);
+                                        }
+                                        await context.close();
+                                        this.ctx.log.debug(`Closed browser context for snapshot ${snapshot.name}`);
+                                    }
+                                }
+                                this.processNext();
+                            } else {
+                                await this.ctx.client.processSnapshot(this.ctx, processedSnapshot, snapshotUuid, discoveryErrors);
+                            }
                         } else {
                             await this.ctx.client.uploadSnapshot(this.ctx, processedSnapshot,  discoveryErrors);
                         }

src/tasks/createBuildExec.ts

@@ -21,7 +21,7 @@ export default (ctx: Context): ListrTask<Context, ListrRendererFactory, ListrRen
                     }
                     if (ctx.build.id === '') {
                         ctx.log.debug('Build creation failed: Build ID is empty');
-                        task.output = chalk.gray('Build creation failed: Build ID is empty');
+                        task.output = chalk.red('Build creation failed: Build ID is empty');
                         throw new Error('SmartUI build creation failed');
                     }
                     task.output = chalk.gray(`build id: ${resp.data.buildId}`);
@@ -44,9 +44,9 @@ export default (ctx: Context): ListrTask<Context, ListrRendererFactory, ListrRen
                     } else if (tunnelResp && tunnelResp.error) {
                         if (tunnelResp.error.message) {
                             if (tunnelResp.error.code && tunnelResp.error.code === 400) {
-                                ctx.log.info(chalk.yellow(tunnelResp.error.message))
+                                ctx.log.warn(tunnelResp.error.message)
                             } else {
-                                ctx.log.info(chalk.yellow(`Error while fetch tunnel details; Either tunnel is not running or tunnel parameters are different`))
+                                ctx.log.warn(`Error while fetch tunnel details; Either tunnel is not running or tunnel parameters are different`)
                             }
                         }
                     }