changes for page height and throwing warning for more than one viewport size

Author: Nick-1234531

src/lib/processSnapshot.ts

@@ -671,14 +671,21 @@ export default async function processSnapshot(snapshot: Snapshot, ctx: Context):
             for (const selector of selectors) {
                 if (selector.startsWith('coordinates=')) {
                     const coordString = selector.replace('coordinates=', '');
-                    const viewportSize = await page.viewportSize();
-                    
-                    if (!viewportSize) {
-                        optionWarnings.add(`for snapshot ${snapshot.name} viewport ${viewportString}, unable to get viewport size for coordinate validation`);
-                        continue;
+                    let pageHeight = height;
+                    if (viewport.height) {
+                      pageHeight = viewport.height;
+                    }
+                    const validation = validateCoordinates(
+                      coordString,
+                      pageHeight,
+                      viewport.width,
+                      snapshot.name
+                    );
+
+
+                    if(renderViewports.length > 1){
+                        optionWarnings.add(`for snapshot ${snapshot.name}, coordinates may not be accurate for multiple viewports`);
                     }
-                    
-                    const validation = validateCoordinates(coordString, viewportSize, snapshot.name, viewportString);
 
 
                     if (!validation.valid) {

src/lib/utils.ts

@@ -669,17 +669,17 @@ function getPageNumber(screenshotName: string): string {
 
 export function validateCoordinates(
     coordString: string, 
-    viewportSize: { width: number, height: number },
-    snapshotName: string,
-    viewportString: string
+    pageHeight: number,
+    pageWidth: number,
+    snapshotName: string
 ): { valid: boolean, error?: string, coords?: { top: number, bottom: number, left: number, right: number } } {
 
     const coords = coordString.split(',').map(Number);
 
     if (coords.length !== 4) {
         return { 
             valid: false, 
-            error: `for snapshot ${snapshotName} viewport ${viewportString}, invalid coordinates format: ${coordString}. Expected: top,bottom,left,right` 
+            error: `for snapshot ${snapshotName}, invalid coordinates format: ${coordString}. Expected: top,bottom,left,right` 
         };
     }
 
@@ -688,42 +688,42 @@ export function validateCoordinates(
     if (coords.some(isNaN)) {
         return { 
             valid: false, 
-            error: `for snapshot ${snapshotName} viewport ${viewportString}, invalid coordinate values: ${coordString}. All values must be numbers` 
+            error: `for snapshot ${snapshotName}, invalid coordinate values: ${coordString}. All values must be numbers` 
         };
     }
 
     if (top < 0 || left < 0 || bottom < 0 || right < 0) {
         return { 
             valid: false, 
-            error: `for snapshot ${snapshotName} viewport ${viewportString}, invalid coordinate bounds: ${coordString}. top,left,bottom,right must be >= 0` 
+            error: `for snapshot ${snapshotName}, invalid coordinate bounds: ${coordString}. top,left,bottom,right must be >= 0` 
         };
     }
 
     if (top >= bottom) {
         return { 
             valid: false, 
-            error: `for snapshot ${snapshotName} viewport ${viewportString}, invalid coordinate bounds: ${coordString}. top must be < bottom` 
+            error: `for snapshot ${snapshotName}, invalid coordinate bounds: ${coordString}. top must be < bottom` 
         };
     }
 
     if (left >= right) {
         return { 
             valid: false, 
-            error: `for snapshot ${snapshotName} viewport ${viewportString}, invalid coordinate bounds: ${coordString}. left must be < right` 
+            error: `for snapshot ${snapshotName}, invalid coordinate bounds: ${coordString}. left must be < right` 
         };
     }
 
-    if (bottom > viewportSize.height) {
+    if (bottom > pageHeight) {
         return { 
             valid: false, 
-            error: `for snapshot ${snapshotName} viewport ${viewportString}, coordinates exceed viewport bounds: ${coordString}. bottom (${bottom}) exceeds viewport height (${viewportSize.height})` 
+            error: `for snapshot ${snapshotName}, coordinates exceed viewport bounds: ${coordString}. bottom (${bottom}) exceeds viewport height (${pageHeight})` 
         };
     }
 
-    if (right > viewportSize.width) {
+    if (right > pageWidth) {
         return { 
             valid: false, 
-            error: `for snapshot ${snapshotName} viewport ${viewportString}, coordinates exceed viewport bounds: ${coordString}. right (${right}) exceeds viewport width (${viewportSize.width})` 
+            error: `for snapshot ${snapshotName}, coordinates exceed viewport bounds: ${coordString}. right (${right}) exceeds viewport width (${pageWidth})` 
         };
     }