Merge pull request #4 from sushobhit-lt/stage

handle screenshot name validations and build errors

Author: sushobhit-lt

packages/cli/src/validate.js

@@ -40,8 +40,12 @@ export function validateScreenshotConfig(configFile, options, log) {
 
     //Check for URLs should not be empty
     for (const screenshot of screenshots) {
+        if (!screenshot.name || screenshot.name == '') {
+            log.error(`Error: Missing screenshot name in ${configFile}`);
+            process.exit(ABNORMAL_EXIT);
+        }
         if (!screenshot.url || screenshot.url == '') {
-            log.error('Error: Missing required URL for screenshot');
+            log.error('Error: Missing required URL for screenshot : '+screenshot.name);
             process.exit(ABNORMAL_EXIT);
         }
         //Check for URLs should valid (like abcd in URL)

packages/core/src/client.js

@@ -115,17 +115,16 @@ function postRequest(url, body, options, log) {
             return response && response.data
         })
         .catch(function (error) {
+            log.debug(error);
             if (error && error.response && error.response.data) {
-                log.debug(error.response.data);
-                log.info('Build Creation Failed');
-                return error.response.data;
-            }
-            if (error.response) {
+                log.error('Build Creation Failed');
+                log.error(error.response.data)
+            } else if (error.response) {
                 log.error('Build creation failed: response: ', error.response.data.error?.message);
             } else {
                 log.error('Build creation failed: Error: ', error);
             }
-            process.exitCode = constants.ABNORMAL_EXIT;
+            process.exit(constants.ABNORMAL_EXIT);
         })
 }