moved constants in constants file

Author: parthlambdatest

src/commander/upload.ts

@@ -9,8 +9,8 @@ import getGitInfo from '../tasks/getGitInfo.js';
 import createBuild from '../tasks/createBuild.js';
 import uploadScreenshots from '../tasks/uploadScreenshots.js';
 import finalizeBuild from '../tasks/finalizeBuild.js';
+import constants from '../lib/constants.js';
 
-const ZIP_EXTENSION = '.zip';
 const command = new Command();
 
 command
@@ -33,7 +33,7 @@ command
             return;
         }
 
-        if (path.extname(directory).toLowerCase() === ZIP_EXTENSION) {
+        if (path.extname(directory).toLowerCase() === constants.ZIP_EXTENSION) {
             ctx.log.debug(`Zips are not accepted.  ${directory}`)
             console.log(`Error: The provided directory ${directory} is a zip file. Zips are not accepted.`);
             return;

src/lib/constants.ts

@@ -67,6 +67,16 @@ export default {
     // log file path
     LOG_FILE_PATH: '.smartui.log',
 
+    // Disallowed Zip Extension
+    ZIP_EXTENSION: '.zip',
+
+    // Magic Numbers 
+    MAGIC_NUMBERS: [
+        { ext: 'jpg', magic: Buffer.from([0xFF, 0xD8, 0xFF]) },
+        { ext: 'jpeg', magic: Buffer.from([0xFF, 0xD8, 0xFF]) },
+        { ext: 'png', magic: Buffer.from([0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A]) },
+    ],
+
     SUPPORTED_MOBILE_DEVICES: {
         'Blackberry KEY2 LE': { os: 'android', viewport: {width: 412, height: 618}},
         'Galaxy A12': { os: 'android', viewport: {width: 360, height: 800}},

src/lib/screenshot.ts

@@ -6,12 +6,6 @@ import * as utils from "./utils.js"
 import constants from './constants.js'
 import chalk from 'chalk';
 
-const magicNumbers = [
-    { ext: 'jpg', magic: Buffer.from([0xFF, 0xD8, 0xFF]) },
-    { ext: 'jpeg', magic: Buffer.from([0xFF, 0xD8, 0xFF]) },
-    { ext: 'png', magic: Buffer.from([0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A]) },
-];
-
 async function captureScreenshotsForConfig(
     ctx: Context,
     browsers: Record<string, Browser>,
@@ -173,7 +167,7 @@ function getImageDimensions(filePath: string): { width: number, height: number }
 
 function isImage(buffer: Buffer): boolean {
 
-    return magicNumbers.some(magic => buffer.slice(0, magic.magic.length).equals(magic.magic));
+    return constants.MAGIC_NUMBERS.some(magic => buffer.slice(0, magic.magic.length).equals(magic.magic));
 }
 
 export async function uploadScreenshots(ctx: Context): Promise<void> {