Merge pull request #97 from greydaemon/DOT-4737

[DOT-4737] Removed null check for buildName flag and sanity checks for empty string values

Author: parthlambdatest

commands/storybook.js

@@ -114,10 +114,29 @@ async function storybook(serve, options) {
                 }
 
                 let commit = await getLastCommit();
-                let baseLine;
-                if (process.env.BASELINE_BRANCH !== undefined && process.env.BASELINE_BRANCH !== null && process.env.BASELINE_BRANCH !== '')
-                    baseLine = process.env.BASELINE_BRANCH 
-                console.log(`Baseline branch set :${baseLine}`)
+                let baseLine = process.env.BASELINE_BRANCH;
+                let currentBranch = process.env.CURRENT_BRANCH;
+                if (baseLine !== null && baseLine !== undefined){
+                    if(baseLine === ''){
+                        const error = {
+                            "error": "MISSING_BRANCH_NAME",
+                            "message": "Error : The baseline branch name environment variable cannot be empty."
+                        };
+                        console.log(JSON.stringify(error, null, 2));
+                        process.exit(1);
+                    }
+                }
+                    
+                if(currentBranch !== null && currentBranch !==undefined){
+                    if(currentBranch === ''){
+                        const error = {
+                            "error": "MISSING_BRANCH_NAME",
+                            "message": "Error : The current branch name environment variable cannot be empty."
+                        };
+                        console.log(JSON.stringify(error, null, 2));
+                        process.exit(1);
+                    }
+                }
                 let payload = {
                     downloadURL: url.substring(url.search(/.com/)+5, url.search(/.zip/)+4),
                     uploadId: uploadId,
@@ -130,14 +149,14 @@ async function storybook(serve, options) {
                         customViewports: storybookConfig.customViewports
                     },
                     git: {
-                        branch: process.env.BRANCH_NAME ? process.env.BRANCH_NAME: commit.branch, 
+                        branch: currentBranch || commit.branch|| '',  
+                        baselineBranch: baseLine || '',
                         commitId: commit.shortHash, 
                         commitAuthor: commit.author.name, 
                         commitMessage: commit.subject, 
                         githubURL: process.env.GITHUB_URL || '',
                     },
                     buildName: buildName,
-                    baseline: baseLine?? "",
                 }
 
                 // Call static render API

index.js

@@ -42,7 +42,7 @@ program.command('storybook')
         await checkUpdate(version, options);
         console.log('\n');
         // Check if buildName is undefined or empty string
-        if (options.buildName === undefined || options.buildName === '') {
+        if (options.buildName === '') {
             const error = {
                 "error": "MISSING_BUILD_NAME",
                 "message": "The --buildName flag requires a value."

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lambdatest/smartui-storybook",
-  "version": "1.1.20",
+  "version": "1.1.21",
   "description": "LambdaTest's command-line interface (CLI) aimed to help you run your SmartUI tests on LambdaTest platform",
   "main": "index.js",
   "repository": {