Add config validation

Author: pinanks

commands/utils/validate.js

@@ -85,4 +85,47 @@ async function validateLatestBuild(options) {
         });
 }
 
-module.exports = { validateProjectToken, validateStorybookUrl, validateStorybookDir, validateLatestBuild };
+function validateConfig(configFile) {
+    // Verify config file exists
+    if (!fs.existsSync(configFile)) {
+        console.log(`[smartui] Error: Config file ${configFile} not found.`);
+        process.exit(1);
+    }
+
+    // Parse JSON
+    let storybookConfig;
+    try {
+        storybookConfig = JSON.parse(fs.readFileSync(configFile)).storybook;
+    } catch (error) {
+        console.log('[smartui] Error: ', error.message);
+        process.exit(1);
+    }
+
+    // Sanity check browsers
+    if (storybookConfig.browsers.length == 0) {
+        console.log('[smartui] Error: Empty browsers list in config.')
+    }
+    storybookConfig.browsers.forEach(element => {
+        if (!(['chrome', 'safari', 'firefox'].includes(element.toLowerCase()))) {
+            console.log('[smartui] Error: Invalid value for browser. Accepted browsers are chrome, safari and firefox');
+            process.exit(0);
+        }
+    });
+
+    // Sanity check resolutions
+    if (storybookConfig.resolutions.length == 0) {
+        console.log('[smartui] Error: Invalid number of resolutions. Min. required - 1')
+    }
+    if (storybookConfig.resolutions.length > 5) {
+        console.log('[smartui] Error: Invalid number of resolutions. Max allowed - 5')
+    }
+    storybookConfig.resolutions.forEach(element => {
+        if (element.length != 2 || element[0] <= 0 || element[1] <= 0) {
+            console.log('[smartui] Error: Invalid resolutions.')
+        }
+    });
+
+    return storybookConfig
+}
+
+module.exports = { validateProjectToken, validateStorybookUrl, validateStorybookDir, validateLatestBuild, validateConfig };

index.js

@@ -3,7 +3,7 @@
 const { Command, Option } = require('commander');
 const program = new Command();
 const { storybook } = require('./commands/storybook');
-const { validateProjectToken, validateLatestBuild } = require('./commands/utils/validate');
+const { validateProjectToken, validateLatestBuild, validateConfig } = require('./commands/utils/validate');
 const { createConfig } = require('./commands/config');
 const { version } = require('./package.json');
 const { checkUpdate } = require('./commands/utils/package');
@@ -36,10 +36,14 @@ program.command('storybook')
     .option('--force-rebuild', 'Force a rebuild of an already existing build.', false)
     .action(async function(serve, options) {
         options.env = program.opts().env || 'prod';
+        if (options.config) {
+            options.config = validateConfig(options.config);
+        }
+
         console.log('SmartUI Storybook CLI v' + version);
         await checkUpdate(version, options);
         console.log('\n');
-        
+
         await validateProjectToken(options);
         if (!options.forceRebuild) await validateLatestBuild(options);
         storybook(serve, options);