Merge pull request #67 from sushobhit-lt/DOT-1974

[Dot 1974] handle custom viewports for storybook

Author: pinanks

commands/storybook.js

@@ -116,7 +116,8 @@ async function storybook(serve, options) {
                         browsers: browsers,
                         resolutions: resolutions,
                         storyIds: storyIds,
-                        waitForTimeout: storybookConfig.waitForTimeout
+                        waitForTimeout: storybookConfig.waitForTimeout,
+                        customViewports: storybookConfig.customViewports
                     },
                     git: {
                         branch: commit.branch,

commands/utils/config.js

@@ -6,12 +6,13 @@ const defaultSmartUIConfig = {
             'safari',
             'edge'
         ],
-        resolutions: [
+        viewports: [
             [1920, 1080]
         ],
         waitForTimeout: 0,
         include: [],
-        exclude: []
+        exclude: [],
+        customViewports: []
     }
 };
 

commands/utils/dom.js

@@ -66,7 +66,7 @@ async function sendDoM(storybookUrl, stories, storybookConfig, options) {
     form.append('commitId', commit.shortHash);
     form.append('commitAuthor', commit.author.name);
     form.append('commitMessage', commit.subject);
-
+    form.append('customViewports', JSON.stringify(storybookConfig.customViewports));
     githubURL = process.env.GITHUB_URL
     if (githubURL) {
        form.append('githubURL', githubURL);

commands/utils/validate.js

@@ -125,7 +125,8 @@ function validateConfig(configFile) {
 
     try {
         validateConfigBrowsers(storybookConfig.browsers);
-        storybookConfig.resolutions = validateConfigResolutions(storybookConfig.resolutions);
+        resolutions = storybookConfig.resolutions || storybookConfig.viewports
+        storybookConfig.resolutions = validateConfigResolutions(resolutions);
     } catch (error) {
         console.log(`[smartui] Error: Invalid config, ${error.message}`);
         process.exit(constants.ERROR_CATCHALL);
@@ -136,7 +137,7 @@ function validateConfig(configFile) {
         storybookConfig.waitForTimeout = 0;
     } else if (storybookConfig.waitForTimeout <= 0 || storybookConfig.waitForTimeout > 30000) {
         console.log('[smartui] Warning: Invalid config, value of waitForTimeout must be > 0 and <= 30000');
-        console.log('If you do not wish to include waitForTimeout parameter, remove it from the config file.');
+        console.log('[smartui] If you do not wish to include waitForTimeout parameter, remove it from the config file.');
         storybookConfig.waitForTimeout = 0;
     }